Allow timeouts to be specified with h values
#548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samgiles
force-pushed
the
sg-timeout-validation
branch
from
430b0ac to
af164a5
Compare
samgiles
changed the title
h values
Signed-off-by: Sam Giles <[email protected]>
samgiles
force-pushed
the
sg-timeout-validation
branch
from
af164a5 to
cf4ed65
Compare
|
Superseded by #549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not certain this is a complete PR as I'm unfamiliar with the codebase. Addresses #547
There's an argument that timeouts shouldn't be so large, but this validation doesn't seem like the right place to enforce that.