Implement conditional remediation #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaneagan
force-pushed
the
conditional-remediation
branch
16 times, most recently
from
93a04eb to
96d997a
Compare
seaneagan
force-pushed
the
conditional-remediation
branch
14 times, most recently
from
9ee3fa0 to
dd87af9
Compare
seaneagan
force-pushed
the
conditional-remediation
branch
from
2668e4d to
25c01a8
Compare
hiddeco
added
area/helm
hiddeco
force-pushed
the
conditional-remediation
branch
4 times, most recently
from
4f00367 to
9838e51
Compare
seaneagan
commented
Aug 21, 2020
hiddeco
force-pushed
the
conditional-remediation
branch
2 times, most recently
from
8a5a975 to
3121f8b
Compare
seaneagan
commented
Aug 21, 2020
hiddeco
force-pushed
the
conditional-remediation
branch
from
3121f8b to
b916aa4
Compare
hiddeco
reviewed
Aug 21, 2020
seaneagan
force-pushed
the
conditional-remediation
branch
from
b745720 to
d60e269
Compare
hiddeco
force-pushed
the
conditional-remediation
branch
from
7b427ed to
856b54b
Compare
|
Tidied it up a bit more @seaneagan, and fixed some panics due to the pointer changes. Some of the end to end tests are still failing, other than that it looks good to go to me. |
seaneagan
force-pushed
the
conditional-remediation
branch
2 times, most recently
from
820e1c9 to
a7730cb
Compare
hiddeco
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Can not thank you enough for your work on this @seaneagan 🥇 🌷
This commit adds support for conditional remediation, enabling the user to: * configure if test failures should be ignored * configure what action should taken when a Helm install or upgrade action fails (e.g. rollback, uninstall) * configure if a failed Helm action should be retried * configure if a failed release should be kept for debugging purposes The previous behaviour where failed Helm tests did not mark the `HelmRelease` as not `Ready` has changed, it now marks them as failed by default. Co-authored-by: Hidde Beydals <[email protected]>
hiddeco
force-pushed
the
conditional-remediation
branch
from
940265c to
a52ba65
Compare
jtyr
pushed a commit
to jtyr/fluxcd-helm-controller
that referenced
this pull request
Dec 14, 2023
add hostNetwork option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41