-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm to 3.7.2 #407
Update helm to 3.7.2 #407
Conversation
Signed-off-by: Casey Buto <[email protected]>
@cbuto have you tested this change and the memory issue went away? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @cbuto
@stefanprodan I didn't get a chance to test it fully under the circumstances that caused the OOM, going to give it a go now though and see what happens! |
@stefanprodan unfortunately, it looks like a memory issue might still exist (at least in our tests) with the helm-controller configured with 1Gi and 1.5Gi of memory. |
@cbuto could you please test with helm 3.8.0? |
@stefanprodan I can give that a go for sure, I did see there is actually some more work being done addressing memory issues here helm/helm#10486 that could be related (hard to tell right now) |
I suspect the PR you are referring to is indeed the thing that (hopefully) resolves this all, and also explains some of the other weird behavior that has been reported recently (about all releases failing). |
After upgrading to Flux 0.25.3, we noticed the memory discussed in a few different issues #349, #351, and #345 started happening again (after pinning the helm-controller to 0.12.2, the issue went away).
The original update to helm 3.7.2 was in this PR but ended up getting downgraded to 3.7.1 in a subsequent PR.
Hopefully this update resolves the memory issues! 🎉
Signed-off-by: Casey Buto [email protected]