Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm to 3.7.2 #407

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Update helm to 3.7.2 #407

merged 1 commit into from
Jan 27, 2022

Conversation

cbuto
Copy link
Contributor

@cbuto cbuto commented Jan 27, 2022

After upgrading to Flux 0.25.3, we noticed the memory discussed in a few different issues #349, #351, and #345 started happening again (after pinning the helm-controller to 0.12.2, the issue went away).

The original update to helm 3.7.2 was in this PR but ended up getting downgraded to 3.7.1 in a subsequent PR.

Hopefully this update resolves the memory issues! 🎉

Signed-off-by: Casey Buto [email protected]

Signed-off-by: Casey Buto <[email protected]>
@makkes makkes added the bug Something isn't working label Jan 27, 2022
@stefanprodan stefanprodan added area/ci CI related issues and pull requests and removed bug Something isn't working labels Jan 27, 2022
@stefanprodan stefanprodan changed the title fix: Update helm to 3.7.2 Update helm to 3.7.2 Jan 27, 2022
@stefanprodan
Copy link
Member

@cbuto have you tested this change and the memory issue went away?

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @cbuto

@stefanprodan stefanprodan merged commit 413717a into fluxcd:main Jan 27, 2022
@cbuto
Copy link
Contributor Author

cbuto commented Jan 27, 2022

@cbuto have you tested this change and the memory issue went away?

@stefanprodan I didn't get a chance to test it fully under the circumstances that caused the OOM, going to give it a go now though and see what happens!

@cbuto
Copy link
Contributor Author

cbuto commented Jan 27, 2022

@stefanprodan unfortunately, it looks like a memory issue might still exist (at least in our tests) with the helm-controller configured with 1Gi and 1.5Gi of memory.

@stefanprodan
Copy link
Member

@cbuto could you please test with helm 3.8.0?

@cbuto
Copy link
Contributor Author

cbuto commented Jan 27, 2022

@stefanprodan I can give that a go for sure, I did see there is actually some more work being done addressing memory issues here helm/helm#10486 that could be related (hard to tell right now)

@hiddeco
Copy link
Member

hiddeco commented Jan 27, 2022

I suspect the PR you are referring to is indeed the thing that (hopefully) resolves this all, and also explains some of the other weird behavior that has been reported recently (about all releases failing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants