-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HelmRelease v2 in flux reconcile
and flux create
#4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
2 times, most recently
from
May 7, 2024 09:41
af4b837
to
c34bac3
Compare
stefanprodan
reviewed
May 9, 2024
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
2 times, most recently
from
May 10, 2024 09:38
aac55b5
to
f2e77db
Compare
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
from
May 10, 2024 12:47
f2e77db
to
68bafa5
Compare
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
3 times, most recently
from
May 10, 2024 15:36
ca7b48d
to
125ace7
Compare
cmd/flux/testdata/helmrelease/reconcile_helmrelease_from_git.golden
Outdated
Show resolved
Hide resolved
If implemented HR with ChartRef can be reconciled with `--with-source`set. Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
3 times, most recently
from
May 11, 2024 20:25
cce80c6
to
354c252
Compare
Signed-off-by: Soule BA <[email protected]>
souleb
force-pushed
the
reconcile-hr-with-chartref
branch
from
May 11, 2024 20:49
354c252
to
5feee5c
Compare
stefanprodan
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @souleb 🥇
stefanprodan
changed the title
Add support for HelmRelease V2 in
Add support for HelmRelease v2 in May 12, 2024
flux reconcile
and flux create
flux reconcile
and flux create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4761