feat: add reconcile source chart command#3675
Merged
stefanprodan merged 2 commits intofluxcd:mainfrom May 25, 2023
Merged
Conversation
somtochiama
reviewed
Mar 14, 2023
raffis
force-pushed
the
feat-reconcilechart
branch
from
8843427 to
4f6de90
Compare
Contributor
Author
|
Updated with latest changes for v1.0.0. Anything I can help with to get this merged? |
Member
|
Thank you for updating it with latest changes 🙇 Some of us are extremely busy with preparations for KubeCon, hence the reduced activities this week. Once the conference storm has settled (or some of the folks not doing preparations have time), this will be looked at. |
|
Thanks @raffis for implementing this feature! I would really love to see this feature out 👍 🙏 |
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
hiddeco
force-pushed
the
feat-reconcilechart
branch
from
4f6de90 to
b8c24f9
Compare
stefanprodan
added
enhancement
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
Reconciling helm charts which are configured as semver are not reconciled via reconcile hr.
This is because the HelmChart does not get annotated.
More details are found here:
flux reconcile source chart#3656Proposal
This pr adds a new command
reconcile source chartwhich also supports the --source flag for the referencing repository.reconcile hr --with-sourcenow supports annotating the entire source tree for a HelmRelease: Repository => Chart => Release.This pr supersedes #3660.
Fixes #3656