Use standardized status condition schema #225
Labels
enhancement
New feature or request
Comments
|
Presumably for helm-controller we'll need to wait for a helm version (likely 3.4) which supports kubernetes 1.19 libraries. |
|
The controller-runtime has been updated to 1.19 in master, we have to wait for a release there as well. |
Most of the time we were/are able to overwrite what Kubernetes libraries we want to use, except for the breaking change they made when |
relu
added a commit
to relu/image-reflector-controller
that referenced
this issue
Nov 3, 2020
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
relu
added a commit
to relu/image-reflector-controller
that referenced
this issue
Nov 4, 2020
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
squaremo
pushed a commit
to relu/image-reflector-controller
that referenced
this issue
Nov 12, 2020
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
|
Implemented in #474. Can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The standardized status condition schema:
kubernetes/enhancements#1624
Is available in kuberentes 1.19 libraries:
https://github.com/kubernetes/apimachinery/blob/release-1.19/pkg/apis/meta/v1/types.go
There are additionally some helper libraries which should be available in an upcoming version:
kubernetes/kubernetes#92717
This for example handles only updating lastTransitionTime if the status actually changes, which
we are not doing currently.
Also
observedGenerationis included as a per-condition field.The text was updated successfully, but these errors were encountered: