-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use standardized status condition schema #225
Comments
Presumably for helm-controller we'll need to wait for a helm version (likely 3.4) which supports kubernetes 1.19 libraries. |
The controller-runtime has been updated to 1.19 in master, we have to wait for a release there as well. |
Most of the time we were/are able to overwrite what Kubernetes libraries we want to use, except for the breaking change they made when |
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
Use the newly introduced standardized Condition type kubernetes/enhancements#1624 Relates to fluxcd/flux2#225 Signed-off-by: Aurel Canciu <[email protected]>
Implemented in #474. Can be closed. |
The standardized status condition schema:
kubernetes/enhancements#1624
Is available in kuberentes 1.19 libraries:
https://github.com/kubernetes/apimachinery/blob/release-1.19/pkg/apis/meta/v1/types.go
There are additionally some helper libraries which should be available in an upcoming version:
kubernetes/kubernetes#92717
This for example handles only updating lastTransitionTime if the status actually changes, which
we are not doing currently.
Also
observedGeneration
is included as a per-condition field.The text was updated successfully, but these errors were encountered: