Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standardized status condition schema #225

Closed
seaneagan opened this issue Sep 11, 2020 · 4 comments
Closed

Use standardized status condition schema #225

seaneagan opened this issue Sep 11, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@seaneagan
Copy link

The standardized status condition schema:
kubernetes/enhancements#1624

Is available in kuberentes 1.19 libraries:
https://github.com/kubernetes/apimachinery/blob/release-1.19/pkg/apis/meta/v1/types.go

There are additionally some helper libraries which should be available in an upcoming version:
kubernetes/kubernetes#92717
This for example handles only updating lastTransitionTime if the status actually changes, which
we are not doing currently.

Also observedGeneration is included as a per-condition field.
@stefanprodan stefanprodan added the enhancement New feature or request label Sep 15, 2020
@seaneagan
Copy link
Author

Presumably for helm-controller we'll need to wait for a helm version (likely 3.4) which supports kubernetes 1.19 libraries.

@stefanprodan
Copy link
Member

The controller-runtime has been updated to 1.19 in master, we have to wait for a release there as well.

@hiddeco
Copy link
Member

hiddeco commented Sep 15, 2020

Presumably for helm-controller we'll need to wait for a helm version (likely 3.4) which supports kubernetes 1.19 libraries.

Most of the time we were/are able to overwrite what Kubernetes libraries we want to use, except for the breaking change they made when context.Context was introduced to all methods.

@relu relu mentioned this issue Nov 1, 2020
Merged
relu added a commit to relu/image-reflector-controller that referenced this issue Nov 3, 2020
@relu
Adopt k8s standardized conditions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
b343113 
Use the newly introduced standardized Condition type kubernetes/enhancements#1624

Relates to fluxcd/flux2#225

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu mentioned this issue Nov 3, 2020
Merged
relu added a commit to relu/image-reflector-controller that referenced this issue Nov 4, 2020
@relu
Adopt k8s standardized conditions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5ee8a38 
Use the newly introduced standardized Condition type kubernetes/enhancements#1624

Relates to fluxcd/flux2#225

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu relu mentioned this issue Nov 4, 2020
Merged
squaremo pushed a commit to relu/image-reflector-controller that referenced this issue Nov 12, 2020
@relu @squaremo
Adopt k8s standardized conditions
ba7800e 
Use the newly introduced standardized Condition type kubernetes/enhancements#1624

Relates to fluxcd/flux2#225

Signed-off-by: Aurel Canciu <aurelcanciu@gmail.com>
@relu
Copy link
Member

relu commented Nov 20, 2020

Implemented in #474. Can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seaneagan @relu @stefanprodan @hiddeco