Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Make it easier to mount known_hosts from a ConfigMap in Helm chart #1142

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

squaremo
Copy link
Member

Addresses #1113, and helps with #1101 by making the chart usable from the integration test (I think).

WIP until I've actually tried the Helm chart install myself.

@squaremo
Copy link
Member Author

Note to self, this may need to alter the howto bit of setup.md, and possibly FAQ.

Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanprodan
Copy link
Member

@squaremo you could also bump Flux version to 1.4.0

@squaremo squaremo changed the title [WIP] Make it easier to mount known_hosts from a ConfigMap Make it easier to mount known_hosts from a ConfigMap Jun 20, 2018
@squaremo
Copy link
Member Author

you could also bump Flux version to 1.4.0

After trying this with Helm, I've realised it needs a release after 1.4.0, since it will mount a ConfigMap over the top of ~/.ssh, and that will break any flux image that doesn't include the change from the first commit. -> I'll do a PR that just includes that first commit (which is safe and won't break existing configs), then we can update the examples and Helm chart once there's a new release out.

@squaremo
Copy link
Member Author

squaremo commented Jun 20, 2018

Note to self: PR for the first bit is #1154. Once that's merged and in a release, rebase this and bump version in Helm chart.

@squaremo squaremo force-pushed the feature/mount-known-hosts branch from c69111b to 70e1143 Compare June 21, 2018 16:23
@squaremo squaremo changed the title Make it easier to mount known_hosts from a ConfigMap Make it easier to mount known_hosts from a ConfigMap in Helm chart Jun 21, 2018
@squaremo
Copy link
Member Author

I removed the change to the example -- it can stay commented out. So this is just about making it possible to tell the Helm chart to include a known_hosts file. @stefanprodan Do you mind checking it again / trying it out? Thank you!

@squaremo squaremo merged commit ed0012d into master Jun 22, 2018
@squaremo squaremo deleted the feature/mount-known-hosts branch June 22, 2018 09:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants