Weird CMake error at build time #1198
-
|
Hi, I am attempting to build flux-sched with Spack on a Rocky 8 system and am seeing a very weird CMake error. At first, I was using |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 20 replies
-
|
It seems to me like the I checked v0.33.1 though and it appears to be there: and the file indeed contains |
Beta Was this translation helpful? Give feedback.
-
|
I see why this is happening. I can fix it really quickly, and will put up a PR shortly, but we should also add a set of the |
Beta Was this translation helpful? Give feedback.
-
|
@vsoch is there any special process we need to use because of the spack package file update checkers or should I just put up a PR directly to spack? |
Beta Was this translation helpful? Give feedback.
-
|
It will work either way - changes into flux packages from spack core will be found and PRd to our flux-framework/spack. If you change it there, the PR will go in the other direction. Note that our builds are regularly (and sporadically) failing because the libsodium source download is not reliable. I don't know any good solutions, but I'm keeping on top of releases and ensuring we run all the update workflows when we have them. |
Beta Was this translation helpful? Give feedback.
-
|
Sounds good, thanks @vsoch. Speaking of, libsodium also posts their official releases on their github repo, maybe that would be more reliable? |
Beta Was this translation helpful? Give feedback.
-
|
I could do a PR to spack, but do you think they would accept it? Worth a shot, because this current state is pretty terrible. |
Beta Was this translation helpful? Give feedback.
-
|
I don't see why not, as long as you explain the reason and that it's still the official upstream. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I looked at the install artifacts that Spack is working with and it looks like the environment variable is not getting defined with |
Beta Was this translation helpful? Give feedback.
-
|
It's two variables, unfortunately with different names, FLUX_SCHED_VERSION is the env var, and FLUX_SCHED_VER is the cmake variable. I see what I did though, it will not fix older versions of sched yet, will have to patch it again, thanks for testing! |
Beta Was this translation helpful? Give feedback.
-
|
Oh, I see! Ok. I was trying a few different experiments to see if I could figure out what was happening. |
Beta Was this translation helpful? Give feedback.
-
|
Ok, the spack PR is updated, it should now pass the define if either the file is missing or the version is below 0.34, which should cover all of them. |
Beta Was this translation helpful? Give feedback.
-
|
That works! Thank you! |
Beta Was this translation helpful? Give feedback.
I see why this is happening. I can fix it really quickly, and will put up a PR shortly, but we should also add a set of the
FLUX_SCHED_VERSIONenv var orFLUX_SCHED_VERto the spack package so it will work for intermediate versions and git checkouts. The bug that's causing this for you @christopherwharrop-noaa is that it's looking for it in the binary rather than src dir, which only works if they are both the same.