job-list: minor code consistency cleanup #5031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
job_list_misc_cleanup
branch
2 times, most recently
from
2300f09 to
372d66b
Compare
This was referenced Mar 30, 2023
Problem: In one test in t2800-jobs-cmd.t, a state count used an incorrect file to determine the number of jobs that failed with a timeout. Solution: Use the correct file to determine the number of jobs that failed due to a timeout.
Problem: An errant single quote existed in a test in t2260-job-list.t. Remove it.
Problem: There was inconsistent tab vs space indentation in t2260-job-list.t. Make all indentation tabs for consistency.
Problem: The variable "exception" is used for the "exception_occurred" job-list field. This is legacy from when only "exception" was returned. Update the variable name to match the field name.
chu11
force-pushed
the
job_list_misc_cleanup
branch
from
372d66b to
6e8b92e
Compare
grondo
approved these changes
Apr 1, 2023
src/common/libjob/jj.c
Outdated
| #include <string.h> | ||
| #include <jansson.h> | ||
|
|
||
| #include "src/common/libccan/ccan/str/str.h" |
There was a problem hiding this comment.
-I$(top_srcdir)/src/common/libccan is specified in the Makefile, so only ccan/str/str.h is required here.
src/common/libjob/test/sign_none.c
Outdated
| #include "src/common/libtap/tap.h" | ||
| #include "src/common/libjob/sign_none.h" | ||
| #include "src/common/libccan/ccan/base64/base64.h" | ||
| #include "src/common/libccan/ccan/str/str.h" |
There was a problem hiding this comment.
Suggested change
| #include "src/common/libccan/ccan/str/str.h" | |
| #include "ccan/str/str.h" |
src/modules/job-list/job_state.c
Outdated
| #include "src/common/libutil/grudgeset.h" | ||
| #include "src/common/libjob/job_hash.h" | ||
| #include "src/common/libidset/idset.h" | ||
| #include "src/common/libccan/ccan/str/str.h" |
There was a problem hiding this comment.
Suggested change
| #include "src/common/libccan/ccan/str/str.h" | |
| #include "ccan/str/str.h" |
src/modules/job-list/job_util.c
Outdated
| #include <assert.h> | ||
|
|
||
| #include "src/common/libutil/errno_safe.h" | ||
| #include "src/common/libccan/ccan/str/str.h" |
There was a problem hiding this comment.
Suggested change
| #include "src/common/libccan/ccan/str/str.h" | |
| #include "ccan/str/str.h" |
Problem: Flux-core is slowly moving to use streq() instead of strcmp() when comparing strings. Some strcmp()s are lingering in libjob. Replace strcmp() with streq() as needed. In a few locations where the "ccan/str/str.h" header was included, update other includes to have similar include paths.
Problem: Flux-core is slowly moving to use streq() instead of strcmp() when comparing strings. Some strcmp()s are lingering in the job-list module. Replace strcmp() with streq() as needed.
chu11
changed the title
chu11
force-pushed
the
job_list_misc_cleanup
branch
from
6e8b92e to
f96b74a
Compare
|
@grondo thanks for the review. updated the title and tweaked per your recommendations. There were a few other "src/common/libccan/cccan/..." includes in some files in |
Codecov Report
@@ Coverage Diff @@
## master #5031 +/- ##
==========================================
+ Coverage 83.14% 83.16% +0.01%
==========================================
Files 445 445
Lines 76529 76529
==========================================
+ Hits 63629 63642 +13
+ Misses 12900 12887 -13
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically is
job-listand things related tojob-list