-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(battery_plus): Added aditional information on device battery #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would prefer that we don't add new functionality if it is not at least covering both Android and iOS (the two main platforms). Ideally with a plan to cover the six of them. Throwing a missing implementation exception leads to bad user experience. I already faced that with the We should probably clarify this in the CONTRIBUTING document. |
Yes I agree @miquelbeltran I hope you can take care of it @rktejesh also build failed please double-check check formatting. |
@miquelbeltran I agree with you. I plan on adding it to other platforms as well. But as for iOS devices due to Apple restrictions it is not possible to retrieve the data from public API's and App store may block the app if we use any private API-See and also this. As for the build failed I assume you are talking about the second test. I have updated two plugins (battery_plus and battery_plus_platform_interface) and since the second test doesn't melos bootstrap the test has not passed. Could you please also add the Hacktoberfest tags. Thanks. |
IMO if those values can only be retrieved for Android then I would encourage you to create an independent plugin for android specific functionality like I will add the hacktoberfest tags but we cannot merge this PR I think. |
@rktejesh did you ever follow through on this? Such a waste to throw away your Android work just because the other platforms are not yet implemented. |
@twogood haven't given it much thought after that. Is it still viable to create this into a standalone plugin only for Android? |
Even if you don't want to maintain it, maybe just add it to its own GitHub repository somewhere. |
Description
Added additional methods to the present battery api to get device battery information such as Battery Capacity, Charging Status, Charge Time Remaining, Current Average, Current Now, Health, Plugged Status, Battery Presence, Scale, Remaining Energy, Technology, Temperature, Voltage.
This change has only been added to android. Other platforms are yet to be implemented
Related Issues
This PR partially closes #460
Checklist
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?