-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeError was thrown building FaIcon-[<'secondaryGlyph'> #171
Comments
You may need to run the update script again. 9.1.0 mainly contained changes for duotone icons |
In my pro override repo? I’m pretty sure I did as I started from scratch at
9.1.0. I’ll add that I’m using v6 beta icons.json and ttfs in the 5.15
repo, but tools update.sh did run ok.
They are working in my Drawer but some pages and bottomnav I get this
error. Very weird.
…On Thu, 10 Jun 2021 at 23:17, Michael Spiss ***@***.***> wrote:
You may need to run the update script again. 9.1.0 mainly contained
changes for duotone icons
|
Just confirmed, ./tools/update.sh was run. |
I tested v6 beta before releasing 9.1.0 and did not find any errors. Can you run the example app in font_awesome_flutter to test wether this is an issue in your app or with this package? |
To explain the error: |
That was my next min test case.
…On Fri, 11 Jun 2021 at 11:13, Michael Spiss ***@***.***> wrote:
I tested v6 beta before releasing 9.1.0 and did not find any errors. Can
you run the example app in font_awesome_flutter to test wether this is an
issue in your app or with this package?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABG66E5VJDTS3VUF4O7IQTTSHOTPANCNFSM46PN4KWA>
.
|
Hmmm,
in the core FA repo of yours updated for fontawesome-pro-6.0.0-beta1-web |
Yeah, they've renamed most icons now which I had to sort in my code: https://fontawesome.com/v5.15/icons/search?style=solid is now: https://fontawesome.com/v6.0/icons/magnifying-glass?style=solid Thanks. |
Switching to this and I can run the app:
but I hit the same error in the example app as I'm getting in my app on quite a few icons as I scroll down. I can share my pro repo with you if you like? I just followed the instructions like normal for pro. The fact that the thin style is there should show that I did it correct? Thanks. |
Full error on Android 11 simulator:
|
And my changes in core repo for pro:
|
Am also experiencing this as of the latest FA pro version. |
I went back to 5.15.3. Works well with 9.10
…On Sat, 19 Jun 2021, 06:52 kyiii, ***@***.***> wrote:
Am also experiencing this as of the latest FA pro version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABG66CRVHU54AQGWNVRAV3TTQWA3ANCNFSM46PN4KWA>
.
|
They've changed the duotone font file's layout for v6, that's why it isn't working anymore. Working on it right now. |
Handy! As well as reverse all the names. Nothing wrong with the names
before.
|
It looks like we have to wait a bit longer for them to finish v6. Currently the documentation (https://fontawesome.com/v6.0) mentions addresses which do not exist within the font files. |
Support for duotone icons has been discontinued with version 10 of font_awesome_flutter. For the reasons why, please have a look at this comment. |
Hi all,
I seem to be getting this on upgrading to Flutter 2.2.1 and I've not changed anything I can see. I've added this to the file in question:
// @dart=2.11
as I'm not fully null safety migrated yet and this may well be nothing to do with FA, but it's all I've got to go on. Any ideas?
Thanks.
The text was updated successfully, but these errors were encountered: