Using WKWebView instead of UIWebView #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing commented code; Using withZoom and hidden values; Verifying WebView instance before "navigate", "evalJavascript", "resize" and "closeWebView".
lejard-h
requested changes
Mar 31, 2018
ios/Classes/FlutterWebviewPlugin.m
Outdated
| if (withZoom != (id)[NSNull null] && [withZoom boolValue]) { | ||
| self.webview.scalesPageToFit = YES; | ||
| self.webview.scrollView.delegate = self; | ||
| _enableZoom = [withZoom boolValue]; | ||
| } | ||
|
|
||
| if (hidden != (id)[NSNull null] && [hidden boolValue]) { |
There was a problem hiding this comment.
so can we remove the condition ?
There was a problem hiding this comment.
🤔 Yes! BOOL values are 0 by default in obj-c, so we don't need to check if it's nil
ios/Classes/FlutterWebviewPlugin.m
Outdated
| self.webview = [[WKWebView alloc] initWithFrame:rc]; | ||
| self.webview.navigationDelegate = self; | ||
| [self.viewController.view addSubview:self.webview]; | ||
|
|
||
| if (withZoom != (id)[NSNull null] && [withZoom boolValue]) { |
There was a problem hiding this comment.
same thing here, can we remove the condition ?
lejard-h
approved these changes
Apr 1, 2018
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
Using WKWebView instead of UIWebView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing commented code;
Using withZoom and hidden values;
Verifying WebView instance before "navigate", "evalJavascript", "resize" and "closeWebView".