Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resizeToAvoidBottomInset to WebviewScaffold; #301

Merged
merged 4 commits into from
Mar 28, 2019
Merged

add resizeToAvoidBottomInset to WebviewScaffold; #301

merged 4 commits into from
Mar 28, 2019

Conversation

gadfly361
Copy link
Contributor

@charafau
Copy link
Collaborator

charafau commented Mar 26, 2019

Hello, thanks for PR. I think I merged similar PR to this one but with resizeToAvoidBottomInset since resizeToAvoidBottomPadding is deprecated ( https://docs.flutter.io/flutter/material/Scaffold/resizeToAvoidBottomPadding.html )

can you check if your issue is fixed?

@gadfly361
Copy link
Contributor Author

@charafau Thanks for pointing out that resizeToAvoidBottomPadding was deprecated in favor of resizeToAvoidBottomInset.

I noticed that the commit you are referring to changed the default of resizeToAvoidBottomInset from true to false; however, it still does not provide a way for the user to choose which boolean value they'd like to use.

This updated PR retains the recent decision to default to false, while giving the user an opportunity to pass in their preference, which I think could be useful.

@gadfly361 gadfly361 changed the title add resizeToAvoidBottomPadding to WebviewScaffold; add resizeToAvoidBottomInset to WebviewScaffold; Mar 27, 2019
@charafau charafau merged commit 35e04b9 into fluttercommunity:master Mar 28, 2019
charafau added a commit that referenced this pull request Apr 7, 2020
add resizeToAvoidBottomInset to WebviewScaffold;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] add resizeToAvoidBottomPadding to WebviewScaffold
2 participants