Add support for passing a list of cookies to be set #238
+15,742
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added reloading (Android)
Added reloading (Android)
Never set minSdk and targetSdk in manifest.
Taking safe areas into account for bottom bars
Allow local files on iOs > 9.0
Added reloading (Android)
from dart2, getCookies throws type conversion error. Refer to https://stackoverflow.com/questions/49824167/breaking-exception-internallinkedhashmapdynamic-dynamic-is-not-a-subtype-o
bugfix: Added google() repository to allprojects to satisfy androidx build rules
Fix iOS local URL support (fixes fluttercommunity#114)
…l-dart Add JavascriptChannel abstraction in dart code
fixed min sdk for android
Prepare for release 0.3.8
This reverts commit b2104ab
Listen javascript function from flutter
Fix master branch
* added initial test support * added travis setup * modified tests * test new travis script * added tests for android * added android unit test support * upgraded script * fixed typo * added execute permissions * configured gradle * configured github actions * updated github actions * added andorid ut * added android yml * renamed files and tasks * removed redundant name * renamed tasks * fixed andorid ut script
…#600) * added callbacks to canGoForward and canGoBack for android * added flutter tests added ios implementation * updated readme
* Fixed ios compilation, added clear cache for ios * added cleaning cache for android * updated readme
craigloftus
force-pushed
the
feature/cookies
branch
from
fc07e70 to
73f43a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for passing a list of cookie objects to be added to the cookie manager of the webview before the initial url is opened, these will be persisted for subsequent requests and can be changed by responses handled by the webview.
I've tested this on an android 9.0 and on an iOS 11 simulator, and I'll be following up with testing it across a wider range of devices when I can get my hands on them.
The approach I've taken on iOS is definitely limited to >=11 due to the use of
httpCookieStore, but I should be able to get it to work for earlier versions if that is required.Also, this is my first time writing java or objective-c, so I apologise in advance for any clangers.