iOS: add IOS delegate, rect, userAgent and evalJavascript #18

pedia · 2017-12-09T09:10:25Z

add UIWebViewDelegate for UIWebView
add rect/hidden argument for the first launch

lejard-h

Thanks for your pull request, can you add your name to the authors list and take a look at my comments ?

lejard-h · 2017-12-09T18:07:18Z

lib/flutter_webview_plugin.dart

    _channel.setMethodCallHandler(_handleMessages);
  }

  Future<Null> _handleMessages(MethodCall call) async {
+    print("_handleMessages $call");


remove print

lejard-h · 2017-12-09T18:07:49Z

lib/flutter_webview_plugin.dart

-  _init() {
+  FlutterWebviewPlugin() : 
+    _channel = const MethodChannel(_kChannel),
+    _event = const EventChannel(_kEvent) {


why a new channel and not use the existing MethodChannel ?

I don't know how to send event via MethodChannel.
https://github.com/flutter/plugins/blob/master/packages/battery/lib/battery.dart

lejard-h · 2017-12-09T18:11:02Z

lib/flutter_webview_plugin.dart

+  final EventChannel _event;
+  Stream<String> _stateChanged;
+
+  Stream<String> get stateChanged {


onUrlChanged Stream already exist for this

If there is a difference could you document it ?

It is difficult to implement onUrlchanged, I will try this.

can you add comment ?
iOS implemented,
Android not implemented

lejard-h · 2017-12-09T18:12:36Z

ios/Classes/FlutterWebviewPlugin.m

    NSNumber *clearCache = call.arguments[@"clearCache"];
    NSNumber *clearCookies = call.arguments[@"clearCookies"];
-    NSNumber *fullScreen = call.arguments[@"fullScreen"];
+    NSNumber *hidden = call.arguments[@"hidden"];


could you document this ? removing fullscreen is a breaking change and I need to know if I can do the same thing for Android

OK. I will add some document.

fullScreen is default.

lejard-h · 2017-12-09T18:15:02Z

ios/Classes/FlutterWebviewPlugin.m

+}
+
+- (void)initWebView:(FlutterMethodCall*)call {
+    // NSNumber *withJavascript = call.arguments[@"withJavascript"];


I have no idea, but can we deactivate/activate javascript for iOS webview ?

I don't think it's easy.

lejard-h · 2017-12-10T13:00:36Z

@toufikzitouni do you have time to review the iOS part ?

add eval javascript sink onUrlChanged ...

Schema

lejard-h · 2017-12-13T10:29:59Z

lib/flutter_webview_plugin.dart

+  ///     android: Implemented
+  ///   [fullScreen]: show in full screen mode, default true
+  ///     iOS WebView: without rect, show in full screen mode
+  ///     android: Not implemented yet


fullscreen is implemented on Android, but hidden is not

lejard-h · 2017-12-13T10:30:39Z

lib/flutter_webview_plugin.dart

+  ///   [rect]: show in rect(not full screen)
+  ///     iOS WebView: worked
+  ///     android: Not implemented yet
+  ///   [enableAppScheme]: false will enable all schemes, true only for


iOS implemented,
Android not implemented

lejard-h · 2017-12-13T10:31:11Z

lib/flutter_webview_plugin.dart

@@ -90,6 +142,10 @@ class FlutterWebviewPlugin {
    await _channel.invokeMethod('launch', args);
  }

+  Future<String> evalJavascript(String code) {


IOS implemented
Android not implemented

lejard-h · 2017-12-13T10:32:21Z

lib/flutter_webview_plugin.dart

-    _channel = const MethodChannel(_kChannel),
-    _event = const EventChannel(_kEvent) {
+  FlutterWebViewPlugin()
+      : _channel = const MethodChannel(_kChannel),


can't we use on MethodChannel instead of 2 channels ?

lejard-h · 2017-12-13T10:34:42Z

lib/flutter_webview_plugin.dart

+  final EventChannel _event;
+  Stream<String> _stateChanged;
+
+  Stream<String> get stateChanged {


can you add comment ?
iOS implemented,
Android not implemented

fix document

android: add rect, fullScreen, userAgent, eval

ios and android more implement

pedia · 2017-12-16T10:09:57Z

@lejard-h
I removed ios event channel, add android implement of rect, userAgent ...

pedia · 2017-12-18T08:48:54Z

@lejard-h

Maybe I should close this pull request, and request a new one.

kpedia added 4 commits December 9, 2017 17:03

iOS: add delegate

1b7a2b1

add hidden in example

c2cbbca

add eval Javascript

8e6ad14

add flag for some scheme

a9f473f

pedia mentioned this pull request Dec 9, 2017

Notify when URL changes #13

Closed

lejard-h requested changes Dec 9, 2017

View reviewed changes

kpedia and others added 2 commits December 12, 2017 12:02

add more document

71da770

add eval javascript sink onUrlChanged ...

Merge pull request #1 from pedia/schema

7ea334d

Schema

lejard-h requested changes Dec 13, 2017

View reviewed changes

kpedia and others added 2 commits December 15, 2017 17:45

fix document

dfd1d0e

Merge pull request #2 from pedia/schema

571e3aa

fix document

pedia changed the title ~~iOS: add delegate and some argument~~ iOS: add IOS delegate, rect, userAgent and evalJavascript Dec 15, 2017

kpedia and others added 2 commits December 16, 2017 18:05

ios: remove event channel

55bb7c3

android: add rect, fullScreen, userAgent, eval

Merge pull request #3 from pedia/schema

72badf1

ios and android more implement

pedia closed this Dec 18, 2017

ronaldG19 mentioned this pull request Aug 7, 2018

Casting from android.webkit #152

Closed

manondidi mentioned this pull request Nov 19, 2018

MissingPluginException but i can see flutter_webview_plugin module in my project #244

Open

sanrixue mentioned this pull request Jul 23, 2019

WebView is not allowed in privileged processes #486

Closed

PrakashJagan mentioned this pull request Apr 20, 2020

Long press (on any text) in web view app crashes for android samsung device #719

Open

stoneLee81 mentioned this pull request May 19, 2020

flutter_webview_plugin with flutter_boost running under android, found exception #750

Open

jims57 mentioned this pull request Jul 31, 2020

Unhandled Exception: MissingPluginException(No implementation found for method close on channel flutter_webview_plugin) #793

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS: add IOS delegate, rect, userAgent and evalJavascript #18

iOS: add IOS delegate, rect, userAgent and evalJavascript #18

pedia commented Dec 9, 2017

lejard-h left a comment

lejard-h Dec 9, 2017

pedia Dec 12, 2017

lejard-h Dec 9, 2017

pedia Dec 12, 2017

lejard-h Dec 9, 2017

lejard-h Dec 9, 2017

pedia Dec 10, 2017

lejard-h Dec 13, 2017

pedia Dec 15, 2017

lejard-h Dec 9, 2017

pedia Dec 10, 2017

lejard-h Dec 9, 2017

pedia Dec 10, 2017

lejard-h commented Dec 10, 2017

lejard-h Dec 13, 2017

pedia Dec 15, 2017

lejard-h Dec 13, 2017

pedia Dec 15, 2017

lejard-h Dec 13, 2017

pedia Dec 15, 2017

lejard-h Dec 13, 2017

lejard-h Dec 13, 2017

pedia commented Dec 16, 2017 •

edited

Loading

pedia commented Dec 18, 2017

iOS: add IOS delegate, rect, userAgent and evalJavascript #18

iOS: add IOS delegate, rect, userAgent and evalJavascript #18

Conversation

pedia commented Dec 9, 2017

lejard-h left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lejard-h commented Dec 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedia commented Dec 16, 2017 • edited Loading

pedia commented Dec 18, 2017

pedia commented Dec 16, 2017 •

edited

Loading