Fix rect capture on WebviewScaffold #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this merge commit published as an update for flutter_webview_plugin on pubdev or I need to point my pubspec.yaml dependency to the github url? |
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
Fix rect capture on WebviewScaffold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128 and fixes commented issues with capturing the size of bottomNav and other chrome. This captures the Rect of the body area so it encompasses all chrome and since the Scaffold obey's the viewInsets for the keyboard it also handles that change.