Add support of HTTP errors #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejard-h
requested changes
Jul 26, 2018
| @@ -3,7 +3,7 @@ | |||
| android:versionCode="1" | |||
| android:versionName="0.0.1"> | |||
|
|
|||
| <uses-sdk android:minSdkVersion="16" android:targetSdkVersion="21" /> | |||
| <uses-sdk android:minSdkVersion="23" android:targetSdkVersion="23" /> | |||
There was a problem hiding this comment.
I don't think min version 23 is a great idea, since flutter support >=16
There was a problem hiding this comment.
You are right, reverted
lib/src/base.dart
Outdated
| @@ -60,6 +60,8 @@ class FlutterWebviewPlugin { | |||
| /// more detail than other events | |||
| Stream<WebViewStateChanged> get onStateChanged => _onStateChanged.stream; | |||
|
|
|||
| Stream<WebViewError> get onError => _onError.stream; | |||
There was a problem hiding this comment.
Could you rename it to onHttpError and WebViewError to WebViewHttpError to be more explicit ?
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.