Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive icons solid color background not working #79

Closed
talamaska opened this issue Jan 24, 2019 · 6 comments
Closed

Adaptive icons solid color background not working #79

talamaska opened this issue Jan 24, 2019 · 6 comments

Comments

@talamaska
Copy link

talamaska commented Jan 24, 2019

flutter_icons:
  image_path: "assets/images/icon.png"
  adaptive_icon_background: "#EA7819"
  android: true
  ios: false

the icon still has white background around it
ran couple of times flutter packages pub run flutter_launcher_icons:main
icons are not regenerated

@talamaska
Copy link
Author

just checked your code you are not handling anywhere solid colors like suggested

@MarkOSullivan94
Copy link
Collaborator

It is being handled here: https://github.com/fluttercommunity/flutter_launcher_icons/blob/master/lib/android.dart#L75

Strange that it's not being generated for you. I'll need to investigate.

@MarkOSullivan94
Copy link
Collaborator

Done a bit of investigating and I'm having no issues here.

Are you missing the adaptive_icon_foreground? I noticed it's not in your yaml_config, adaptive icons wont work unless there's a foreground icon with a transparent background (check example project which has a red house adaptive icon foreground icon).

If you have a foreground in your config, check your device and make sure it supports adaptive icons.

screenshot_1550330714
screenshot_1550330617

@talamaska
Copy link
Author

yes I was missing that adaptive_icon_foreground, but I didn't know it has relation to reading the adaptive_icon_background. Please be more clear with the docs.

@erperejildo
Copy link

Done a bit of investigating and I'm having no issues here.

Are you missing the adaptive_icon_foreground? I noticed it's not in your yaml_config, adaptive icons wont work unless there's a foreground icon with a transparent background (check example project which has a red house adaptive icon foreground icon).

If you have a foreground in your config, check your device and make sure it supports adaptive icons.

screenshot_1550330714
screenshot_1550330617

Can you provide code? I had exactly the same situation after 2 years and I didn't know both params needed to go together

@marcglasberg
Copy link

@MarkOSullivan94 The docs are really not clear. To be honest I still don't know what should be done there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants