Skip to content

Conversation

Ortes
Copy link
Contributor

@Ortes Ortes commented Sep 19, 2025

No description provided.

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.71%. Comparing base (d228479) to head (a4d847b).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/chewie_player.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   43.84%   43.71%   -0.14%     
==========================================
  Files          21       21              
  Lines        1601     1606       +5     
==========================================
  Hits          702      702              
- Misses        899      904       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegotori
Copy link
Collaborator

Two things:

  1. You need to make this configurable from the ChewieConttoller. In other words, you need to make this opt-in.
  2. When making this configurable, you also need to make the threshold dismissing on swipe a configurable value, defaulting to a reasonable value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants