Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auto Play Flag In DefaultAssetPickerViewerBuilderDelegate #585

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Auto Play Flag In DefaultAssetPickerViewerBuilderDelegate #585

wants to merge 1 commit into from

Conversation

yujune
Copy link

@yujune yujune commented May 21, 2024

Add autoPlay flag in DefaultAssetPickerViewerBuilderDelegate to auto play video, audio and live photo.

Result

Simulator Screen Recording - iPhone 15 Pro Max - 2024-05-21 at 18 55 03

AlexV525
AlexV525 requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally you need to add docs for the new field. Also it is worth it to add it to the AssetPickerConfig. I'd prefer the name as shouldPreviewAutoPlay additionally.

@yujune yujune requested a review from LeGoffMael as a code owner June 30, 2024 06:23
@yujune yujune requested a review from AlexV525 July 1, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeGoffMael LeGoffMael Awaiting requested review from LeGoffMael LeGoffMael is a code owner

@AlexV525 AlexV525 Awaiting requested review from AlexV525 AlexV525 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yujune @AlexV525 @yujunetee