Revert "fetchFullSizeVideo will cause a loop and return file path before export session process done." #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore export session process done."
|
Except for PMImageUtil, UIImage/NSImage should not appear in the code, PMImage should be used instead. The define of PMImage: #if TARGET_OS_IOS
typedef UIImage PMImage;
#endif
#if TARGET_OS_OSX
typedef NSImage PMImage;
#endifIf we want to convert the PMImage to NSData, use the |
|
Sorry about PR #478 . I will try to use PMImage instead of UIImage and check the MacOS compatibility again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #478
Not compatible with macOS.
Related #484 .