Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchFullSizeVideo will cause a loop and return file path before export session process done. #477

Closed
wants to merge 3 commits into from
Closed

fetchFullSizeVideo will cause a loop and return file path before export session process done. #477

wants to merge 3 commits into from

Conversation

JimmyTai
Copy link

  1. Fix fetchFullSizeVideo flow logic. Avoid keeping call fetchFullSizeVideo when progress is 1.0. This operation cause a loop and return ile path before export session process done.
  2. Change requestAVAssetForVideo to requestExportSessionForVideo. Avoid iCloud file export failure. Ref: 视频导出失败 banchichen/TZImagePickerController#1073
  3. Add modification date as file name prefix. Avoid to get the cache file if user modified the video.

JimmyTai added 2 commits April 16, 2021 14:37
fix iCloud video export session error
07c5d41 
1. Fix fetchFullSizeVideo flow logic. Avoid keeping call fetchFullSizeVideo when progress is 1.0. This operation cause a loop.
2. Change requestAVAssetForVideo to requestExportSessionForVideo. Avoid iCloud file export failure. Ref: banchichen/TZImagePickerController#1073
3. Add modification date as file name prefix. Avoid to get the cache file if user modified it.
avoid loop calling for fetchFullSizeImageFile
cc10a8d
@JimmyTai JimmyTai marked this pull request as ready for review April 16, 2021 06:57
@AlexV525 AlexV525 requested a review from CaiJingLong April 16, 2021 06:59
@JimmyTai JimmyTai closed this Apr 16, 2021
@JimmyTai JimmyTai reopened this Apr 16, 2021
@JimmyTai JimmyTai closed this Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaiJingLong CaiJingLong Awaiting requested review from CaiJingLong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JimmyTai