-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extended_network_image_provider.dart #5
Update extended_network_image_provider.dart #5
Conversation
Fixes build errors caused by Flutter 1.5.9-pre.106 update. Fixes grammar and spelling
thank for check spelling,i will do this change. and i think we should not do some change just for Flutter 1.5.9-pre.106 update, almost users are not in this version. |
It's a cast to the type explicitly, that's all. It should still work on
older versions. I haven't tested it on older versions though
…On Thu, May 2, 2019, 3:06 AM zmtzawqlp ***@***.***> wrote:
Closed #5 <#5>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPYO7IUIOVPZLLHMHXVUYTPTK4IZANCNFSM4HJ3BXPA>
.
|
old version can't build successfully, i have tested it |
Ok. So what will you do? It doesn't build successfully for the new version
without it. The flutter team just updates the package and lists a breaking
change in the changelog. Users still have the option to stay on the
old version by using version constraints since that's what it's for.
|
codes are base on flutter 1.1.5 (NetworkImage), if any one find some codes are broken, |
I'm sorry, I don't understand
…On Thu, May 2, 2019, 6:35 PM zmtzawqlp ***@***.***> wrote:
codes are base on flutter 1.1.5 (NetworkImage), if any one find some codes
are broken,
please fix them base on your flutter version, would't maintain codes for
every version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFPYO7J3DTNFRHZBNDACMZLPTOJHBANCNFSM4HJ3BXPA>
.
|
user can fix broken code by themself, base on the their version .we can't force user to update to lastest version |
The code is in your package. You don't have to force users to use the
newest version. They can stay on the old package version. This is what the
Flutter team did with all their packages when updating to AndroidX. All
users who were not ready stayed on old packages. It's your package, though,
so it's your decision, but if you do implement the changes, then all users can use your package. If you don't, only users on older Flutter versions can.
|
if have any bug fix or new function for extended image in the future, we can't tell user , you must use flutter 1.5.9. i will update this till flutter team make 1.5.9 as stable version, thanks for your suggestion |
Thank you as well |
Fixes build errors caused by Flutter 1.5.9-pre.106 update.
Fixes grammar and spelling