Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extended_network_image_provider.dart #5

Conversation

ThinkDigitalSoftware
Copy link

Fixes build errors caused by Flutter 1.5.9-pre.106 update.
Fixes grammar and spelling

Fixes build errors caused by Flutter 1.5.9-pre.106 update.
Fixes grammar and spelling
@zmtzawqlp
Copy link
Member

thank for check spelling,i will do this change. and i think we should not do some change just for Flutter 1.5.9-pre.106 update, almost users are not in this version.

@zmtzawqlp zmtzawqlp closed this May 2, 2019
@ThinkDigitalSoftware
Copy link
Author

ThinkDigitalSoftware commented May 2, 2019 via email

@zmtzawqlp
Copy link
Member

old version can't build successfully, i have tested it

@ThinkDigitalSoftware
Copy link
Author

ThinkDigitalSoftware commented May 3, 2019 via email

@zmtzawqlp
Copy link
Member

codes are base on flutter 1.1.5 (NetworkImage), if any one find some codes are broken,
please fix them base on your flutter version, would't maintain codes for every version.

@ThinkDigitalSoftware
Copy link
Author

ThinkDigitalSoftware commented May 3, 2019 via email

@zmtzawqlp
Copy link
Member

user can fix broken code by themself, base on the their version .we can't force user to update to lastest version

@ThinkDigitalSoftware
Copy link
Author

ThinkDigitalSoftware commented May 3, 2019 via email

@zmtzawqlp
Copy link
Member

if have any bug fix or new function for extended image in the future, we can't tell user , you must use flutter 1.5.9. i will update this till flutter team make 1.5.9 as stable version, thanks for your suggestion

@ThinkDigitalSoftware
Copy link
Author

Thank you as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants