Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create flutter-for-ios.md #938

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Create flutter-for-ios.md #938

merged 3 commits into from
Apr 12, 2018

Conversation

rock3r
Copy link
Contributor

@rock3r rock3r commented Apr 9, 2018

This PR creates the page for the new Flutter for iOS devs. It does not contain any content except for the intro (tweaked from the one in the Flutter for Android devs page).

Content will come in subsequent PRs, and we aren't adding the page to the sidebar yet — we'll do it when it's ready to go. For now it'll only accessible at http://flutter.io/flutter-for-ios/ (once the PR is merged).

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Apr 9, 2018
@Hixie
Copy link
Contributor

Hixie commented Apr 10, 2018

Is there any reason to land this before the content exists?

@rock3r
Copy link
Contributor Author

rock3r commented Apr 10, 2018

@Hixie the agreement with @mjohnsullivan is that we're going to do smaller PRs, one per section, as we go instead of one big one when we're done with the document. This way it should be easier to review, and you get content faster (and we can change course faster if need be). If we have the file on your side we can then start doing the section PRs.

Unless, I misunderstood what you meant. If you prefer we can merge this with the first PR which contains the Views section, and then do subsequent sections as previously outlined.

We'd only make the page reachable via sidebar when we're done with the document, still.

@mjohnsullivan
Copy link
Contributor

mjohnsullivan commented Apr 10, 2018

I'm fine with landing this in stages, but we should mark/head the page as WIP to inform users, though they're unlikely to come across is as the page is not linked from home page yet.

LGTM, but with agreement from @Hixie. Otherwise, we can do this in a branch.

@rock3r
Copy link
Contributor Author

rock3r commented Apr 10, 2018

Can defo add a "WIP" warning at the very top for now. Will do shortly

@rock3r
Copy link
Contributor Author

rock3r commented Apr 11, 2018

I have added the WIP notice, works for you now Matt and Ian? Let me know if you want to make this PR against a feature branch as well — just create the feature branch for me and I'll change the target.

@mjohnsullivan
Copy link
Contributor

Let's go with merging it here and keeping it unlinked until finished.

@mjohnsullivan
Copy link
Contributor

LGTM

@mjohnsullivan mjohnsullivan merged commit 760f9d2 into flutter:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants