Adding macOS impeller info #9114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighajarett
requested review from
atsansone,
parlough and
sfshaza2
as code owners
Contributor
Author
|
@chinmaygarde FYI. @sfshaza2 this is for the next stable release |
|
Visit the preview URL for this PR (updated for commit da5010a): https://flutter-docs-prod--pr9114-impeller-macos-o80r05ym.web.app (expires Mon, 14 Aug 2023 19:25:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
atsansone
added
fix.copy
sfshaza2
reviewed
Jul 25, 2023
Contributor
|
lgtm will defer to lgt @sfshaza2 |
sfshaza2
reviewed
Jul 26, 2023
sfshaza2
reviewed
Jul 26, 2023
sfshaza2
approved these changes
Jul 26, 2023
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm with a few minor fixes
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this should go live for 3.13
Issues fixed by this PR (if any): #8908
Presubmit checklist