Skip to content

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 21, 2023

breaking change doc for flutter/packages#4227

Presubmit checklist

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 56248f0):

https://flutter-docs-prod--pr8919-chunhtai-patch-1-w0cysyr6.web.app

(expires Wed, 05 Jul 2023 22:31:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d5ba327eec813901cac8396c4f458b02288624ab

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chunhtai. It sounds like we'll also need a breaking change page?

@sfshaza2 sfshaza2 merged commit 63c83db into main Jun 22, 2023
@sfshaza2 sfshaza2 deleted the chunhtai-patch-1 branch June 22, 2023 17:34
@chunhtai
Copy link
Contributor Author

Thanks, @chunhtai. It sounds like we'll also need a breaking change page?

Did you mean an entry in here? https://docs.flutter.dev/release/breaking-changes

This is for go_router, a first party package, not for flutter framework. I think this doesn't need one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants