-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Introduce a migration guide for 3.10 new Zone error #8683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Migration guide for flutter/flutter#122836
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this document! The background and migration guide read well and make sense to me.
I noted a few issues. Could you also add a link to this doc from the breaking changes index for 3.10? https://github.com/flutter/website/blob/main/src/release/breaking-changes/index.md?plain=1#L43-L44
Co-authored-by: Parker Lougheed <[email protected]>
|
Visit the preview URL for this PR (updated for commit bce00f0): https://flutter-docs-prod--pr8683-hixie-patch-1-zg5b0cmh.web.app (expires Tue, 30 May 2023 18:54:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
Done. Also fixed the missing items that were in that list. |
|
Thanks! Those link definitions were mostly there by accident and weren't released yet in 3.10 or were already in the list above. I pushed fixes so that the index now matches the state of things. |
|
Thanks. I got a bit confused with the list there when doing the merge. |
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this and fixing those issues. Looks good to me!
parlough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this and fixing those issues. Looks good to me!
Migration guide for flutter/flutter#122836
Presubmit checklist