Skip to content

Migration guide for window singleton deprecation #8283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
goderbauer merged 8 commits into from
Mar 23, 2023
Merged

Migration guide for window singleton deprecation #8283

goderbauer merged 8 commits into from
Mar 23, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Feb 17, 2023 •
edited
Loading

Fixes flutter/flutter#116929.

Presubmit checklist

@goderbauer
Copy link
Member Author

goderbauer commented Feb 17, 2023

@pdblasi-google Could you fill in the testing framework details? I left some TODOs for those. I think it makes sense that we cover those deprecations in the same migration guide to keep everything together.

@goderbauer goderbauer mentioned this pull request Feb 17, 2023
Closed
33 tasks
loic-sharma
loic-sharma reviewed Feb 17, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Feb 17, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Feb 17, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Feb 17, 2023
View reviewed changes
dkwingsmt
dkwingsmt reviewed Feb 17, 2023
View reviewed changes
loic-sharma
loic-sharma reviewed Feb 17, 2023
View reviewed changes
dkwingsmt
dkwingsmt reviewed Feb 17, 2023
View reviewed changes
@atsansone atsansone added the review.tech Awaiting Technical Review label Feb 22, 2023
@pdblasi-google pdblasi-google mentioned this pull request Mar 4, 2023
Closed
This was referenced Mar 8, 2023
Merged
Merged
goderbauer
goderbauer commented Mar 21, 2023
View reviewed changes
@goderbauer goderbauer marked this pull request as ready for review March 21, 2023 16:28
@goderbauer goderbauer requested a review from parlough as a code owner March 21, 2023 16:28
@goderbauer goderbauer changed the title [WIP] Migration guide for window singleton deprecation Migration guide for window singleton deprecation Mar 21, 2023
goderbauer
goderbauer commented Mar 21, 2023
View reviewed changes
@goderbauer
Copy link
Member Author

goderbauer commented Mar 22, 2023

@sfshaza2 could you review this when you have a chance?

sfshaza2
sfshaza2 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@goderbauer goderbauer merged commit b91b087 into flutter:main Mar 23, 2023
@goderbauer goderbauer deleted the windowSingleton branch March 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma left review comments

@dkwingsmt dkwingsmt dkwingsmt left review comments

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@khanhnwin khanhnwin Awaiting requested review from khanhnwin

@domesticmouse domesticmouse Awaiting requested review from domesticmouse

@johnpryan johnpryan Awaiting requested review from johnpryan

@atsansone atsansone Awaiting requested review from atsansone

@parlough parlough Awaiting requested review from parlough

+1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review.tech Awaiting Technical Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

☂️ Deprecate window singleton

6 participants

@goderbauer @loic-sharma @dkwingsmt @sfshaza2 @pdblasi-google @atsansone