Skip to content

Upgrade Jekyll to 3.3.1#342

Merged
mit-mit merged 3 commits into
flutter:masterfrom
mit-mit:upgradejekyll
Jan 6, 2017
Merged

Upgrade Jekyll to 3.3.1#342
mit-mit merged 3 commits into
flutter:masterfrom
mit-mit:upgradejekyll

Conversation

@mit-mit

@mit-mit mit-mit commented Jan 5, 2017

Copy link
Copy Markdown
Member
  1. Upgrade Jekyll from 2.4.0 to 3.3.1 (fixes flutter/website uses a very old version of jekyll (2.4.0) which is incompatible with Ruby 2.4 flutter#7317)

  2. Make getting started instructions in readme easier to follow and more self contained

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jan 5, 2017
@mit-mit

mit-mit commented Jan 5, 2017

Copy link
Copy Markdown
Member Author

This was tested on my personal Mac with Ruby 2.3.1, and on a clean Mac (a VM) with Ruby 2.4.

It will not work on corp ubuntu as that has Ruby 2.0.

@sethladd

sethladd commented Jan 5, 2017

Copy link
Copy Markdown
Contributor

lgtm

@mit-mit mit-mit merged commit 2249191 into flutter:master Jan 6, 2017
mit-mit added a commit that referenced this pull request Jan 6, 2017
Oops, the readme.md update in #342 should have said Ruby 2.2.2 -- that is what the travis job is running:

```
19.39s$ rvm install 2.2.2
Searching for binary rubies, this might take some time.
Found remote file https://rubies.travis-ci.org/ubuntu/12.04/x86_64/ruby-2.2.2.tar.bz2
Checking requirements for ubuntu.
Requirements installation successful.
```
@mit-mit mit-mit mentioned this pull request Jan 6, 2017
mit-mit added a commit that referenced this pull request Jan 6, 2017
Oops, the readme.md update in #342 should have said Ruby 2.2.2 -- that is what the travis job is running:

```
19.39s$ rvm install 2.2.2
Searching for binary rubies, this might take some time.
Found remote file https://rubies.travis-ci.org/ubuntu/12.04/x86_64/ruby-2.2.2.tar.bz2
Checking requirements for ubuntu.
Requirements installation successful.
```
@mit-mit mit-mit deleted the upgradejekyll branch January 6, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter/website uses a very old version of jekyll (2.4.0) which is incompatible with Ruby 2.4

3 participants