Skip to content

Add AndroidX migration docs#3080

Merged
sfshaza2 merged 4 commits into
flutter:masterfrom
blasten:androidx
Oct 10, 2019
Merged

Add AndroidX migration docs#3080
sfshaza2 merged 4 commits into
flutter:masterfrom
blasten:androidx

Conversation

@blasten

@blasten blasten commented Oct 10, 2019

Copy link
Copy Markdown

This doc replaces the existing page https://flutter.dev/docs/development/packages-and-plugins/androidx-compatibility.

I added this page under development since it targets all types of Flutter projects.

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 10, 2019
@blasten blasten requested review from mklim and sfshaza2 October 10, 2019 00:43

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A grammatical nit to fix but, otherwise, looks good. Thanks for remembering to set up forwarding for the deleted file! LGTM, once the nit is fixed.

Comment thread src/docs/development/androidx-migration.md Outdated
@sfshaza2

Copy link
Copy Markdown
Contributor

Also, I see that Travis is encountering some link problems. Can you fix?

http://localhost:4002/docs/codelabs/layout-basics
- (1224:0) 'Text class' => http://localhost:4002/docs/codelabs/layout-basics#text-class (HTTP 200 but missing anchor)
http://localhost:4002/docs/development/androidx-migration
- (999:41) 'develope..' => http://localhost:4002/docs/development/developer.android.com/studio (HTTP 404)
- (999:41) 'develope..' => http://localhost:4002/docs/development/developer.android.com/studio (HTTP 404)

@sfshaza2 sfshaza2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mklim mklim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG modulo one question.


### What if my app is migrated to AndroidX, but not all of the plugins I use?

The Flutter tool uses Jetifier to automatically migrate Flutter plugins using

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we enabled building the plugins as AARs by default? My most recent understanding is that we still have compatibility problems here, but I could be missing something.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it's now enabled by default. However, plugins are built as AAR only when the build failed and the heuristic we have for detecting AndroidX failure is true.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My interpretation of this convo is that we're good to go. :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, LGTM! :)

@sfshaza2 sfshaza2 merged commit 5d44c86 into flutter:master Oct 10, 2019
@blasten blasten deleted the androidx branch October 10, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants