Add CupertinoScrollbar to the catalog#2584
Merged
Merged
Conversation
googlebot
added
the
cla: yes
redbrogdon
approved these changes
Apr 10, 2019
redbrogdon
left a comment
redbrogdon
left a comment
Contributor
There was a problem hiding this comment.
LGTM, though it'd be good to get a stamp of approval from @Sfshaza as well.
| }, | ||
| { | ||
| "name": "CupertinoScrollbar", | ||
| "description": "An iOS-style scrollbar that appears while scrolling lists", |
Contributor
There was a problem hiding this comment.
What about "An iOS-style scrollbar that indicates which portion of a scrollable widget is currently visible?" That's more in line with the API docs and avoids implying that the scrollbar is just for use with lists.
Member
Author
There was a problem hiding this comment.
yup, your wording is better. Changed.
sfshaza2
reviewed
Apr 11, 2019
sfshaza2
left a comment
sfshaza2
left a comment
Contributor
There was a problem hiding this comment.
Other than a small niggle about the URL for the API website, LGTM!
| "Cupertino (iOS-style widgets)" | ||
| ], | ||
| "subcategories": [], | ||
| "link": "https://docs.flutter.io/flutter/cupertino/CupertinoScrollbar-class.html", |
Contributor
There was a problem hiding this comment.
Please use api.flutter.dev
Member
Author
There was a problem hiding this comment.
replaced everywhere in the file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.