Conversation
googlebot
added
the
cla: yes
chalin
reviewed
Oct 16, 2018
chalin
left a comment
chalin
left a comment
Contributor
There was a problem hiding this comment.
Pls see inlined comments.
| issue]({{site.repo.this}}/issues). | ||
|
|
||
| {% comment %} | ||
| # TODO (Not for publication) |
Contributor
There was a problem hiding this comment.
How about putting this in an issue (or our shared doc) instead of embedding this in the docs page?
Contributor
Author
There was a problem hiding this comment.
Yes, definitely. I was just throwing out ideas when preparing for our last stakeholder meeting.
Contributor
There was a problem hiding this comment.
The to-do list is still in the doc.
|
|
||
| ```terminal | ||
| $ flutter doctor | ||
| $ flutter doctor [-v] |
Contributor
There was a problem hiding this comment.
The prose before this line contains "run the following command", but by adding [-v] this line becomes more a "usage synopsis". Options that come to mind:
- Revert this change
- Drop the brackets so that it becomes
$ flutter doctor -v - Keep the change but:
- Update the prose (to not say "run the following command"), and
- Remove
terminalas the code-block language - Remove the leading
$
Contributor
There was a problem hiding this comment.
This point wasn't addressed.
| 1. Select **File > New Flutter Project**. | ||
| 1. Select **Flutter application** as the project type, and press **Next**. | ||
| 1. Enter a project name, such as `myapp`, and press **Next**. | ||
| 1. Select **Flutter application** as the project type, and press Next. |
Contributor
There was a problem hiding this comment.
AFAIK, per guidelines, UI elements like Next should be in bold.
Contributor
There was a problem hiding this comment.
This point wasn't addressed.
| 1. Select **Flutter application** as the project type, and press Next. | ||
| 1. Make sure that the **Flutter SDK Path** text field specifies the | ||
| location of the SDK. Install the SDK if you haven't yet done so. | ||
| 1. Enter a project name (for example, `myapp`), and press Next. |
Contributor
There was a problem hiding this comment.
This point wasn't addressed.
|
|
||
| ```terminal | ||
| $ flutter doctor | ||
| $ flutter doctor [-v] |
Contributor
There was a problem hiding this comment.
See earlier comment about this.
Contributor
There was a problem hiding this comment.
This point wasn't addressed.
Contributor
There was a problem hiding this comment.
Well, this PR seemed to be messed up, too. So annoying.
chalin
reviewed
Oct 25, 2018
| <path fill="#f4b400" fill-opacity="0.2346" d="m88.1811 420.73227l794.7087 0l0 83.74805l-794.7087 0z" fill-rule="evenodd"/> | ||
| <path fill="#424242" d="m98.352974 458.9663l0 -11.453125l8.484375 0l0 1.9375l-6.171875 0l0 2.53125l5.75 0l0 1.9375l-5.75 0l0 3.109375l6.390625 0l0 1.9375l-8.703125 0zm10.484375 -8.296875l2.03125 0l0 1.125q1.078125 -1.3125 2.578125 -1.3125q0.796875 0 1.375 0.328125q0.59375 0.328125 0.96875 0.984375q0.546875 -0.65625 1.171875 -0.984375q0.640625 -0.328125 1.359375 -0.328125q0.921875 0 1.546875 0.375q0.640625 0.359375 0.953125 1.078125q0.21875 0.53125 0.21875 1.71875l0 5.3125l-2.1875 0l0 -4.75q0 -1.234375 -0.234375 -1.59375q-0.296875 -0.46875 -0.9375 -0.46875q-0.453125 0 -0.859375 0.28125q-0.40625 0.28125 -0.59375 0.828125q-0.171875 0.546875 -0.171875 1.71875l0 3.984375l-2.203125 0l0 -4.546875q0 -1.21875 -0.125 -1.5625q-0.109375 -0.359375 -0.359375 -0.53125q-0.234375 -0.171875 -0.65625 -0.171875q-0.515625 0 -0.921875 0.28125q-0.40625 0.265625 -0.578125 0.78125q-0.171875 0.515625 -0.171875 1.71875l0 4.03125l-2.203125 0l0 -8.296875zm14.3046875 8.296875l0 -11.453125l2.1875 0l0 4.125q1.015625 -1.15625 2.40625 -1.15625q1.5156326 0 2.5000076 1.09375q1.0 1.09375 1.0 3.15625q0 2.125 -1.015625 3.28125q-1.0 1.140625 -2.4531326 1.140625q-0.703125 0 -1.40625 -0.359375q-0.6875 -0.359375 -1.1875 -1.046875l0 1.21875l-2.03125 0zm2.171875 -4.328125q0 1.28125 0.40625 1.90625q0.578125 0.875 1.515625 0.875q0.734375 0 1.2343826 -0.625q0.515625 -0.625 0.515625 -1.953125q0 -1.421875 -0.515625 -2.046875q-0.5156326 -0.640625 -1.3125076 -0.640625q-0.796875 0 -1.328125 0.625q-0.515625 0.609375 -0.515625 1.859375zm12.492195 1.6875l2.1875 0.359375q-0.421875 1.203125 -1.328125 1.84375q-0.90625 0.625 -2.28125 0.625q-2.15625 0 -3.203125 -1.421875q-0.8125 -1.125 -0.8125 -2.859375q0 -2.0625 1.078125 -3.21875q1.078125 -1.171875 2.71875 -1.171875q1.859375 0 2.921875 1.21875q1.078125 1.21875 1.03125 3.75l-5.5 0q0.015625 0.96875 0.515625 1.515625q0.515625 0.546875 1.28125 0.546875q0.515625 0 0.859375 -0.28125q0.359375 -0.28125 0.53125 -0.90625zm0.125 -2.21875q-0.015625 -0.953125 -0.484375 -1.453125q-0.46875 -0.5 -1.140625 -0.5q-0.71875 0 -1.1875 0.53125q-0.46875 0.515625 -0.46875 1.421875l3.28125 0zm11.5859375 4.859375l-2.046875 0l0 -1.21875q-0.5 0.703125 -1.203125 1.0625q-0.6875 0.34375 -1.390625 0.34375q-1.421875 0 -2.453125 -1.15625q-1.015625 -1.15625 -1.015625 -3.21875q0 -2.109375 0.984375 -3.203125q1.0 -1.09375 2.515625 -1.09375q1.390625 0 2.40625 1.15625l0 -4.125l2.203125 0l0 11.453125zm-5.859375 -4.328125q0 1.328125 0.359375 1.921875q0.53125 0.859375 1.484375 0.859375q0.765625 0 1.296875 -0.640625q0.53125 -0.65625 0.53125 -1.9375q0 -1.421875 -0.515625 -2.046875q-0.515625 -0.640625 -1.328125 -0.640625q-0.78125 0 -1.3125 0.625q-0.515625 0.625 -0.515625 1.859375zm15.6328125 4.328125l-2.046875 0l0 -1.21875q-0.5 0.703125 -1.203125 1.0625q-0.6875 0.34375 -1.390625 0.34375q-1.421875 0 -2.453125 -1.15625q-1.015625 -1.15625 -1.015625 -3.21875q0 -2.109375 0.984375 -3.203125q1.0 -1.09375 2.515625 -1.09375q1.390625 0 2.40625 1.15625l0 -4.125l2.203125 0l0 11.453125zm-5.859375 -4.328125q0 1.328125 0.359375 1.921875q0.53125 0.859375 1.484375 0.859375q0.765625 0 1.296875 -0.640625q0.53125 -0.65625 0.53125 -1.9375q0 -1.421875 -0.515625 -2.046875q-0.515625 -0.640625 -1.328125 -0.640625q-0.78125 0 -1.3125 0.625q-0.515625 0.625 -0.515625 1.859375zm12.8203125 1.6875l2.1875 0.359375q-0.421875 1.203125 -1.328125 1.84375q-0.90625 0.625 -2.28125 0.625q-2.15625 0 -3.203125 -1.421875q-0.8125 -1.125 -0.8125 -2.859375q0 -2.0625 1.078125 -3.21875q1.078125 -1.171875 2.71875 -1.171875q1.859375 0 2.921875 1.21875q1.078125 1.21875 1.03125 3.75l-5.5 0q0.015625 0.96875 0.515625 1.515625q0.515625 0.546875 1.28125 0.546875q0.515625 0 0.859375 -0.28125q0.359375 -0.28125 0.53125 -0.90625zm0.125 -2.21875q-0.015625 -0.953125 -0.484375 -1.453125q-0.46875 -0.5 -1.140625 -0.5q-0.71875 0 -1.1875 0.53125q-0.46875 0.515625 -0.46875 1.421875l3.28125 0zm6.0703125 4.859375l-2.1875 0l0 -8.296875l2.03125 0l0 1.171875q0.53125 -0.828125 0.9375 -1.09375q0.421875 -0.265625 0.953125 -0.265625q0.75 0 1.453125 0.40625l-0.6875 1.921875q-0.546875 -0.359375 -1.03125 -0.359375q-0.453125 0 -0.78125 0.25q-0.3125 0.25 -0.5 0.921875q-0.1875 0.65625 -0.1875 2.78125l0 2.5625z" fill-rule="nonzero"/> | ||
| <path fill="#424242" d="m97.8686 477.9663l2.40625 -11.453125l4.78125 0q1.234375 0 1.859375 0.28125q0.625 0.28125 1.03125 0.984375q0.40625 0.6875 0.40625 1.546875q0 0.703125 -0.296875 1.4375q-0.28125 0.734375 -0.734375 1.21875q-0.4375 0.46875 -0.890625 0.71875q-0.453125 0.234375 -0.96875 0.359375q-1.09375 0.25 -2.21875 0.25l-2.875 0l-0.96875 4.65625l-1.53125 0zm2.78125 -5.953125l2.515625 0q1.46875 0 2.15625 -0.3125q0.6875 -0.3125 1.09375 -0.953125q0.421875 -0.65625 0.421875 -1.390625q0 -0.5625 -0.21875 -0.90625q-0.21875 -0.359375 -0.625 -0.53125q-0.390625 -0.171875 -1.515625 -0.171875l-2.9375 0l-0.890625 4.265625zm7.625 5.953125l2.390625 -11.453125l1.421875 0l-2.390625 11.453125l-1.421875 0zm9.2578125 -1.03125q-0.734375 0.625 -1.421875 0.921875q-0.671875 0.296875 -1.4375 0.296875q-1.15625 0 -1.859375 -0.671875q-0.703125 -0.6875 -0.703125 -1.734375q0 -0.703125 0.3125 -1.234375q0.328125 -0.53125 0.84375 -0.859375q0.53125 -0.328125 1.28125 -0.46875q0.484375 -0.09375 1.8125 -0.140625q1.328125 -0.0625 1.90625 -0.28125q0.171875 -0.578125 0.171875 -0.96875q0 -0.484375 -0.359375 -0.765625q-0.5 -0.390625 -1.4375 -0.390625q-0.890625 0 -1.46875 0.390625q-0.5625 0.390625 -0.8125 1.125l-1.4375 -0.125q0.4375 -1.234375 1.390625 -1.890625q0.953125 -0.65625 2.390625 -0.65625q1.546875 0 2.4375 0.734375q0.6875 0.546875 0.6875 1.421875q0 0.65625 -0.1875 1.53125l-0.46875 2.0625q-0.21875 0.984375 -0.21875 1.609375q0 0.390625 0.171875 1.125l-1.421875 0q-0.125 -0.40625 -0.171875 -1.03125zm0.53125 -3.171875q-0.296875 0.109375 -0.640625 0.171875q-0.34375 0.0625 -1.140625 0.140625q-1.234375 0.109375 -1.75 0.28125q-0.5 0.15625 -0.765625 0.53125q-0.25 0.359375 -0.25 0.8125q0 0.59375 0.40625 0.984375q0.421875 0.375 1.171875 0.375q0.703125 0 1.34375 -0.375q0.65625 -0.375 1.03125 -1.03125q0.375 -0.671875 0.59375 -1.890625zm6.0859375 3.046875l-0.234375 1.171875q-0.515625 0.125 -0.984375 0.125q-0.84375 0 -1.34375 -0.421875q-0.375 -0.3125 -0.375 -0.84375q0 -0.28125 0.203125 -1.265625l1.0 -4.8125l-1.109375 0l0.21875 -1.09375l1.125 0l0.421875 -2.046875l1.625 -0.96875l-0.640625 3.015625l1.390625 0l-0.234375 1.09375l-1.375 0l-0.96875 4.578125q-0.171875 0.875 -0.171875 1.046875q0 0.25 0.140625 0.390625q0.140625 0.125 0.46875 0.125q0.46875 0 0.84375 -0.09375zm1.3359375 1.15625l1.5 -7.203125l-1.265625 0l0.234375 -1.09375l1.265625 0l0.234375 -1.1875q0.1875 -0.875 0.390625 -1.265625q0.20313263 -0.390625 0.6406326 -0.640625q0.453125 -0.265625 1.234375 -0.265625q0.53125 0 1.5625 0.234375l-0.265625 1.234375q-0.71875 -0.1875 -1.203125 -0.1875q-0.40625 0 -0.625 0.203125q-0.21875 0.203125 -0.375 0.984375l-0.1875 0.890625l1.578125 0l-0.21875 1.09375l-1.578125 0l-1.5156326 7.203125l-1.40625 0zm4.492195 -3.15625q0 -2.421875 1.4375 -4.015625q1.171875 -1.3125 3.09375 -1.3125q1.5 0 2.40625 0.9375q0.921875 0.9375 0.921875 2.53125q0 1.421875 -0.578125 2.65625q-0.578125 1.234375 -1.640625 1.890625q-1.0625 0.65625 -2.25 0.65625q-0.96875 0 -1.765625 -0.40625q-0.78125 -0.421875 -1.203125 -1.171875q-0.421875 -0.765625 -0.421875 -1.765625zm1.421875 -0.140625q0 1.171875 0.5625 1.78125q0.5625 0.609375 1.421875 0.609375q0.453125 0 0.890625 -0.1875q0.453125 -0.1875 0.828125 -0.5625q0.390625 -0.375 0.65625 -0.84375q0.28125 -0.484375 0.4375 -1.046875q0.25 -0.765625 0.25 -1.484375q0 -1.125 -0.578125 -1.734375q-0.5625 -0.625 -1.421875 -0.625q-0.65625 0 -1.203125 0.3125q-0.546875 0.3125 -1.0 0.921875q-0.4375 0.609375 -0.640625 1.421875q-0.203125 0.8125 -0.203125 1.4375zm7.2265625 3.296875l1.734375 -8.296875l1.25 0l-0.34375 1.6875q0.640625 -0.953125 1.25 -1.40625q0.609375 -0.46875 1.25 -0.46875q0.421875 0 1.046875 0.296875l-0.578125 1.3125q-0.375 -0.265625 -0.8125 -0.265625q-0.734375 0 -1.515625 0.828125q-0.78125 0.828125 -1.234375 2.984375l-0.703125 3.328125l-1.34375 0zm5.328125 0l1.734375 -8.296875l1.40625 0l-0.28125 1.359375q0.78125 -0.875 1.40625 -1.203125q0.625 -0.34375 1.34375 -0.34375q0.78125 0 1.296875 0.40625q0.515625 0.40625 0.6875 1.140625q0.625 -0.78125 1.328125 -1.15625q0.703125 -0.390625 1.46875 -0.390625q1.046875 0 1.5625 0.5q0.515625 0.484375 0.515625 1.375q0 0.375 -0.171875 1.265625l-1.125 5.34375l-1.40625 0l1.140625 -5.484375q0.140625 -0.671875 0.140625 -0.96875q0 -0.40625 -0.265625 -0.640625q-0.25 -0.234375 -0.71875 -0.234375q-0.625 0 -1.28125 0.390625q-0.65625 0.375 -1.03125 1.0q-0.359375 0.625 -0.625 1.90625l-0.84375 4.03125l-1.421875 0l1.171875 -5.609375q0.125 -0.5625 0.125 -0.8125q0 -0.40625 -0.25 -0.65625q-0.25 -0.25 -0.65625 -0.25q-0.609375 0 -1.265625 0.390625q-0.65625 0.375 -1.078125 1.0625q-0.40625 0.6875 -0.671875 1.953125l-0.828125 3.921875l-1.40625 0zm18.367188 -3.703125l1.5 -0.140625l-0.015625 0.390625q0 0.671875 0.296875 1.21875q0.3125 0.546875 1.015625 0.859375q0.703125 0.296875 1.671875 0.296875q1.375 0 2.09375 -0.59375q0.734375 -0.609375 0.734375 -1.390625q0 -0.53125 -0.390625 -0.984375q-0.390625 -0.4375 -2.125 -1.1875q-1.359375 -0.578125 -1.84375 -0.890625q-0.78125 -0.515625 -1.15625 -1.109375q-0.359375 -0.59375 -0.359375 -1.359375q0 -0.890625 0.484375 -1.59375q0.484375 -0.71875 1.421875 -1.09375q0.9375 -0.375 2.109375 -0.375q1.390625 0 2.34375 0.46875q0.96875 0.46875 1.40625 1.25q0.4375 0.78125 0.4375 1.5q0 0.0625 -0.015625 0.234375l-1.46875 0.109375q0 -0.484375 -0.09375 -0.75q-0.15625 -0.484375 -0.484375 -0.8125q-0.328125 -0.328125 -0.90625 -0.515625q-0.5625 -0.203125 -1.28125 -0.203125q-1.25 0 -1.9375 0.5625q-0.53125 0.421875 -0.53125 1.140625q0 0.421875 0.21875 0.75q0.21875 0.328125 0.78125 0.65625q0.40625 0.21875 1.9375 0.890625q1.234375 0.546875 1.703125 0.859375q0.625 0.421875 0.953125 1.015625q0.34375 0.578125 0.34375 1.328125q0 0.9375 -0.578125 1.71875q-0.5625 0.78125 -1.5625 1.21875q-1.0 0.4375 -2.28125 0.4375q-1.953125 0 -3.1875 -0.84375q-1.21875 -0.859375 -1.234375 -3.0625zm9.375 6.890625l2.40625 -11.484375l1.3125 0l-0.25 1.15625q0.734375 -0.765625 1.296875 -1.046875q0.578125 -0.296875 1.21875 -0.296875q1.1875 0 1.96875 0.859375q0.78125 0.859375 0.78125 2.46875q0 1.296875 -0.4375 2.375q-0.421875 1.0625 -1.046875 1.71875q-0.625 0.640625 -1.265625 0.953125q-0.640625 0.296875 -1.3125 0.296875q-1.484375 0 -2.3125 -1.515625l-0.9375 4.515625l-1.421875 0zm2.8125 -6.578125q0 0.921875 0.125 1.28125q0.203125 0.515625 0.640625 0.828125q0.453125 0.3125 1.03125 0.3125q1.21875 0 1.96875 -1.375q0.75 -1.375 0.75 -2.796875q0 -1.0625 -0.5 -1.625q-0.5 -0.578125 -1.25 -0.578125q-0.546875 0 -1.015625 0.28125q-0.453125 0.28125 -0.84375 0.859375q-0.390625 0.5625 -0.65625 1.390625q-0.25 0.8125 -0.25 1.421875zm12.8828125 0.5625l1.375 0.140625q-0.296875 1.03125 -1.359375 1.953125q-1.0625 0.921875 -2.546875 0.921875q-0.921875 0 -1.6875 -0.421875q-0.765625 -0.4375 -1.171875 -1.25q-0.40625 -0.8125 -0.40625 -1.84375q0 -1.359375 0.625 -2.640625q0.640625 -1.28125 1.640625 -1.890625q1.0 -0.625 2.15625 -0.625q1.484375 0 2.375 0.921875q0.890625 0.921875 0.890625 2.515625q0 0.609375 -0.109375 1.25l-6.109375 0q-0.03125 0.234375 -0.03125 0.4375q0 1.15625 0.53125 1.78125q0.53125 0.609375 1.3125 0.609375q0.71875 0 1.421875 -0.46875q0.703125 -0.484375 1.09375 -1.390625zm-4.109375 -2.046875l4.65625 0q0.015625 -0.21875 0.015625 -0.3125q0 -1.0625 -0.53125 -1.625q-0.53125 -0.578125 -1.375 -0.578125q-0.90625 0 -1.65625 0.625q-0.734375 0.625 -1.109375 1.890625zm12.6484375 1.84375l1.40625 0.15625q-0.53125 1.546875 -1.515625 2.3125q-0.96875 0.75 -2.21875 0.75q-1.359375 0 -2.203125 -0.875q-0.828125 -0.875 -0.828125 -2.453125q0 -1.359375 0.53125 -2.671875q0.546875 -1.3125 1.546875 -1.984375q1.0 -0.6875 2.296875 -0.6875q1.328125 0 2.109375 0.75q0.78125 0.75 0.78125 2.0l-1.390625 0.09375q0 -0.796875 -0.453125 -1.234375q-0.453125 -0.453125 -1.1875 -0.453125q-0.84375 0 -1.46875 0.546875q-0.625 0.53125 -0.984375 1.640625q-0.359375 1.09375 -0.359375 2.109375q0 1.0625 0.46875 1.59375q0.46875 0.53125 1.15625 0.53125q0.6875 0 1.3125 -0.515625q0.640625 -0.53125 1.0 -1.609375zm4.28125 -6.828125l0.328125 -1.59375l1.40625 0l-0.328125 1.59375l-1.40625 0zm-2.0625 9.859375l1.734375 -8.296875l1.40625 0l-1.734375 8.296875l-1.40625 0zm3.8046875 0l1.5 -7.203125l-1.265625 0l0.234375 -1.09375l1.265625 0l0.234375 -1.1875q0.1875 -0.875 0.390625 -1.265625q0.203125 -0.390625 0.640625 -0.640625q0.453125 -0.265625 1.234375 -0.265625q0.53125 0 1.5625 0.234375l-0.265625 1.234375q-0.71875 -0.1875 -1.203125 -0.1875q-0.40625 0 -0.625 0.203125q-0.21875 0.203125 -0.375 0.984375l-0.1875 0.890625l1.578125 0l-0.21875 1.09375l-1.578125 0l-1.515625 7.203125l-1.40625 0zm6.2578125 -9.859375l0.328125 -1.59375l1.40625 0l-0.328125 1.59375l-1.40625 0zm-2.0625 9.859375l1.734375 -8.296875l1.40625 0l-1.734375 8.296875l-1.40625 0zm9.3359375 -3.03125l1.40625 0.15625q-0.53125 1.546875 -1.515625 2.3125q-0.96875 0.75 -2.21875 0.75q-1.359375 0 -2.203125 -0.875q-0.828125 -0.875 -0.828125 -2.453125q0 -1.359375 0.53125 -2.671875q0.546875 -1.3125 1.546875 -1.984375q1.0 -0.6875 2.296875 -0.6875q1.328125 0 2.109375 0.75q0.78125 0.75 0.78125 2.0l-1.390625 0.09375q0 -0.796875 -0.453125 -1.234375q-0.453125 -0.453125 -1.1875 -0.453125q-0.84375 0 -1.46875 0.546875q-0.625 0.53125 -0.984375 1.640625q-0.359375 1.09375 -0.359375 2.109375q0 1.0625 0.46875 1.59375q0.46875 0.53125 1.15625 0.53125q0.6875 0 1.3125 -0.515625q0.640625 -0.53125 1.0 -1.609375z" fill-rule="nonzero"/> | ||
| <path fill="#f4b400" d="m230.83989 461.004l178.99214 0l0 26.929108l-178.99214 0z" fill-rule="evenodd"/> |
Contributor
There was a problem hiding this comment.
Why is this new SVG file so much bigger? Maybe it contained embedded artwork ... which partly defeats the purpose of having an SVG.
Contributor
There was a problem hiding this comment.
I don't know. I copied it from the wiki.
Contributor
There was a problem hiding this comment.
How about we see if we can get the original sources?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chalin, please review.