[dash] Updates for widgets pages#1459
Merged
Merged
Conversation
googlebot
added
the
cla: yes
fertolg
commented
Oct 11, 2018
| <a class="card" href="/development/ui/widgets/{{section.id}}"> | ||
| <div class="card-body"> | ||
| <header class="card-title">{{section.name}}</header> | ||
| <p class="card-text">{{section.description | escape}}</p> |
Contributor
Author
There was a problem hiding this comment.
If I don't escape here, one of the descriptions contains html (a link), which should be fine, but for some reason when it outputs it doesn't seem to be outputting correctly and it totally messes up the second card.
fertolg
force-pushed
the
widgets-catalog
branch
2 times, most recently
from
b3f96ec to
98b8cc2
Compare
Contributor
|
@fertolg, this seems to be failing because it can't find the widgets. They are currently in /api-and-reference/widgets. |
- adds bootstrap cards for widget catalog and the widget index - removes “flutter by google” nav logo - reorganizes styles to keep cards more consistent across different pages (showcase, widgets, etc).
fertolg
force-pushed
the
widgets-catalog
branch
from
98b8cc2 to
7f99712
Compare
Contributor
Author
|
Thanks @Sfshaza ! Fixed the broken links and the build is now green. I'll submit this PR so that I can move along with other things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.