Skip to content

[dash] "Get started > Test drive": copyedits and figure fix#1447

Merged
chalin merged 7 commits into
dashfrom
chalin-test-drive-figure-1011
Oct 11, 2018
Merged

[dash] "Get started > Test drive": copyedits and figure fix#1447
chalin merged 7 commits into
dashfrom
chalin-test-drive-figure-1011

Conversation

@chalin

@chalin chalin commented Oct 11, 2018

Copy link
Copy Markdown
Contributor
  • Move start-app images into assets folder
  • Move _app-figure.md into _includes so it can be shared
  • Regenerated starter-app image (the previous one was out-of-date)
  • "Get started > Test drive"
    • Use a <figure> with a caption instead of an <img>
    • Put a (light gray) border around the image
  • Copyedits to "Get started" pages

Staged at https://ng2-io.firebaseapp.com/get-started/test-drive


Screenshots

Image formatting was:

screen shot 2018-10-11 at 11 05 47

It is now:

screen shot 2018-10-11 at 12 07 10

@chalin chalin requested a review from Sfshaza October 11, 2018 15:46
@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Oct 11, 2018
@chalin chalin force-pushed the chalin-test-drive-figure-1011 branch from 012fb74 to a2a87bc Compare October 11, 2018 16:01
@Sfshaza

Sfshaza commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

That's better. Thanks! LGTM

@chalin chalin merged commit 2347074 into dash Oct 11, 2018
@chalin chalin deleted the chalin-test-drive-figure-1011 branch October 11, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants