[dash] Travis: use language:dart, reinstate link checking#1237
Merged
Conversation
chalin
added
the
infra.structure
googlebot
added
the
cla: yes
chalin
force-pushed
the
chalin-travis-dart-0906
branch
from
September 6, 2018 11:55
85a0dd3 to
bb7cd9a
Compare
chalin
changed the title
language:dartlanguage:dart, reinstate link checking, unpin firebase-tools
chalin
force-pushed
the
chalin-travis-dart-0906
branch
11 times, most recently
from
September 6, 2018 15:25
2e85107 to
0787aee
Compare
- Travis: use `language:dart` - Reinstate link checking, but now using the linkcheck Dart tool - Use locally installed npm firebase-tools and superstatic
chalin
force-pushed
the
chalin-travis-dart-0906
branch
from
September 6, 2018 15:38
0787aee to
ec0d870
Compare
chalin
changed the title
language:dart, reinstate link checking, unpin firebase-toolslanguage:dart, reinstate link checking
filiph
reviewed
Sep 6, 2018
| @@ -0,0 +1,57 @@ | |||
| #!/usr/bin/env bash | |||
| # | |||
| # Tweaked a copy of https://github.com/dart-lang/site-shared/blob/master/tool/serve.sh | |||
Contributor
There was a problem hiding this comment.
[small nit] It would be awesome to share this directly at some point.
Contributor
Author
There was a problem hiding this comment.
Yes! I gave the rest of the team a heads-up during our standup today: site-shared will be integrated as a submodule via the next PR.
filiph
reviewed
Sep 6, 2018
|
|
||
| # FIXME(Temporary): | ||
| /web-analogs | ||
| /flutter-for-* |
Contributor
There was a problem hiding this comment.
This looks like a glob pattern instead of regexp. I recommend rewriting to /flutter-for-.
Contributor
Author
There was a problem hiding this comment.
Oh, right, thanks for the reminder.
Those are all on their way out as of @Sfshaza's next PR.
chalin
added a commit
that referenced
this pull request
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1239
Contributes to #1185