Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Support for WebAssembly (Wasm)" page #11367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnpryan
Copy link
Contributor

Resolves #11319

cc: @kevmoo

@johnpryan johnpryan requested review from sfshaza2, parlough and a team as code owners November 6, 2024 17:12
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 1fe03ed):

https://flutter-docs-prod--pr11367-issue-11319-webassembly-a1292l4d.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, otherwise lgtm.

### Run or build your app

To run the app with Wasm for development or testing,
use the `--wasm` flag with the `flutter run command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use the `--wasm` flag with the `flutter run command.
use the `--wasm` flag with the `flutter run` command.

```

## Known limitations
Alternatively, you can use differences in number representations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As re-written, how is this a limitation? Can you make it more clear?

[Chromium and V8][] released stable support for WasmGC in Chromium 119.
Note that Chrome on iOS uses WebKit, which doesn't yet [support WasmGC][].
Firefox announced stable support for WasmGC in Firefox 120,
but currently doesn't work due to a [known limitation](#known-limitations).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear what the limitation is.

@sfshaza2 sfshaza2 added the review.await-update Awaiting Updates after Edits label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review.await-update Awaiting Updates after Edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Support for WebAssembly (Wasm)" page
3 participants