Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next] Update example snippets for 3.27 deprecations and breaking changes #11281

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[Next] Update example snippets for 3.27 deprecations and breaking changes #11281

wants to merge 5 commits into from

Conversation

parlough
Copy link
Member

No description provided.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 16, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit e8940ab):

https://flutter-docs-prod--pr11281-feat-3-27-build-tq3utgk5.web.app

@parlough
Copy link
Member Author

@gaaclarke When migrating the Color usages, I noticed the withOpacity deprecation points to withValues but withAlpha (and friends) doesn't. Should those methods also be deprecated? Or at least have a documentation note to say they only work with sRGB colors?

@parlough parlough marked this pull request as ready for review October 17, 2024 19:30
@parlough parlough requested review from sfshaza2 and a team as code owners October 17, 2024 19:30
@parlough parlough marked this pull request as draft October 17, 2024 19:30
sfshaza2
sfshaza2 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yowza!!! lgtm

ericwindmill
ericwindmill approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ericwindmill ericwindmill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 approved these changes

@ericwindmill ericwindmill ericwindmill approved these changes

@RedBrogdon RedBrogdon Awaiting requested review from RedBrogdon RedBrogdon is a code owner automatically assigned from flutter/website-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@parlough @flutter-website-bot @ericwindmill @sfshaza2