Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update get-started/test-drive page VsCode Instructions #10856

Closed
1 task done
ldps21 opened this issue Jul 7, 2024 · 1 comment
Closed
1 task done

Update get-started/test-drive page VsCode Instructions #10856

ldps21 opened this issue Jul 7, 2024 · 1 comment
Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.

Comments

@ldps21
Copy link
Contributor

ldps21 commented Jul 7, 2024 •
edited
Loading

Page URL

https://docs.flutter.dev/get-started/test-drive

Page source

https://github.com/flutter/website/blob/4256aad9d0ce20511acd2432b4e208eebbf89190/src/_includes/docs/install/test-drive/vscode.md

Describe the problem

The test drive page is instructing to install the dart extension which was by default installed previously in the process of setting up flutter by the VsCode Flutter extension.

Expected fix

Update the page instructions to inform about this.

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@ldps21 ldps21 added the from.page-issue Reported in a reader-filed concern label Jul 7, 2024
This was referenced Jul 7, 2024
Closed
Closed
Merged
@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs labels Jul 8, 2024
sfshaza2 added a commit that referenced this issue Jul 8, 2024
@ldps21 @sfshaza2
Updated test drive page VsCode instructions (#10859)
02219cd 
_Description of what this PR is changing or adding, and why:_
The test drive page is instructing to install the dart extension which
was by
default installed previously by the VsCode Flutter extension.
_Issues fixed by this PR (if any):_
#10856
_PRs or commits this PR depends on (if any):_

## Presubmit checklist

- [ ] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.

---------

Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
@sfshaza2
Copy link
Contributor

sfshaza2 commented Jul 8, 2024

Fixed by #10859

@sfshaza2 sfshaza2 closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atsansone @ldps21 @sfshaza2