Skip to content

Fix master CI for simplistic_editor #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domesticmouse merged 2 commits into from
Jun 28, 2023
Merged

Fix master CI for simplistic_editor #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf0d68
fix master CI
Renzo-Olivares Jun 28, 2023
ea24572
Add `simplistic_editor` to master CI
domesticmouse Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions simplistic_editor/lib/basic_text_input_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,6 @@ class BasicTextInputClientState extends State<BasicTextInputClient>
obscureText:
false, // This is a non-private text field that does not require obfuscation.
offset: position,
onCaretChanged: null,
rendererIgnoresPointer: true,
cursorWidth: 2.0,
cursorHeight: null,
Expand Down Expand Up @@ -1007,7 +1006,6 @@ class _Editable extends MultiChildRenderObjectWidget {
required this.obscuringCharacter,
required this.obscureText,
required this.offset,
this.onCaretChanged,
this.rendererIgnoresPointer = false,
required this.cursorWidth,
this.cursorHeight,
Expand Down Expand Up @@ -1059,7 +1057,6 @@ class _Editable extends MultiChildRenderObjectWidget {
final TextHeightBehavior? textHeightBehavior;
final TextWidthBasis textWidthBasis;
final ViewportOffset offset;
final CaretChangedHandler? onCaretChanged;
final bool rendererIgnoresPointer;
final double cursorWidth;
final double? cursorHeight;
Expand Down Expand Up @@ -1096,7 +1093,6 @@ class _Editable extends MultiChildRenderObjectWidget {
locale: locale ?? Localizations.maybeLocaleOf(context),
selection: value.selection,
offset: offset,
onCaretChanged: onCaretChanged,
ignorePointer: rendererIgnoresPointer,
obscuringCharacter: obscuringCharacter,
obscureText: obscureText,
Expand Down Expand Up @@ -1138,7 +1134,6 @@ class _Editable extends MultiChildRenderObjectWidget {
..locale = locale ?? Localizations.maybeLocaleOf(context)
..selection = value.selection
..offset = offset
..onCaretChanged = onCaretChanged
..ignorePointer = rendererIgnoresPointer
..textHeightBehavior = textHeightBehavior
..textWidthBasis = textWidthBasis
Expand Down
3 changes: 1 addition & 2 deletions tool/flutter_ci_script_master.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ declare -ar PROJECT_NAMES=(
"simple_shader"
# TODO(DomesticMouse): Dependency 'flutter_layout_grid' fails to compile. https://github.com/shyndman/flutter_layout_grid/issues/91
# "simplistic_calculator"
# TODO(DomesticMouse): Undefined class 'CaretChangedHandler'. https://github.com/flutter/samples/issues/1923
# "simplistic_editor"
"simplistic_editor"
"testing_app"
"veggieseasons"
"web_embedding/element_embedding_demo"
Expand Down