Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Removes unnecessary overrides. #6669

Merged
auto-submit merged 4 commits into from
Nov 4, 2022
Merged

[ci] Removes unnecessary overrides. #6669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99f45d9
remove unnecessary overrides
pq Nov 3, 2022
4660bb6
Update mock so tools_tests checks pass.
ditman Nov 4, 2022
0e632bc
Update CHANGELOG NEXT entries.
ditman Nov 4, 2022
ba48f88
Pin git to 2.0.x
ditman Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/video_player/video_player_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
* Updates code for `no_leading_underscores_for_local_identifiers` lint.
* Updates minimum Flutter version to 2.10.
* Fixes violations of new analysis option use_named_constants.
* Removes an unnecessary override in example code.

## 2.3.9

Expand Down
5 changes: 0 additions & 5 deletions packages/video_player/video_player_android/example/lib/mini_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,6 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
void _updatePosition(Duration position) {
value = value.copyWith(position: position);
}

@override
void removeListener(VoidCallback listener) {
super.removeListener(listener);
}
}

/// Widget that displays the video controlled by [controller].
Expand Down
1 change: 1 addition & 0 deletions packages/video_player/video_player_avfoundation/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Adds an integration test for a bug where the aspect ratios of some HLS videos are incorrectly inverted.
* Removes an unnecessary override in example code.

## 2.3.7

Expand Down
5 changes: 0 additions & 5 deletions packages/video_player/video_player_avfoundation/example/lib/mini_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,6 @@ class MiniController extends ValueNotifier<VideoPlayerValue> {
void _updatePosition(Duration position) {
value = value.copyWith(position: position);
}

@override
void removeListener(VoidCallback listener) {
super.removeListener(listener);
}
}

/// Widget that displays the video controlled by [controller].
Expand Down
6 changes: 6 additions & 0 deletions script/tool/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## NEXT

* Pins `package:git` dependency to `2.0.x` until `dart >=2.18.0` becomes our
oldest legacy.
* Updates test mocks.

## 0.13.0

* Renames `all-plugins-app` to `create-all-packages-app` to clarify what it
Expand Down
3 changes: 2 additions & 1 deletion script/tool/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ dependencies:
collection: ^1.15.0
colorize: ^3.0.0
file: ^6.1.0
git: ^2.0.0
# Pin git to 2.0.x until dart >=2.18 is legacy
git: '>=2.0.0 <2.1.0'
http: ^0.13.3
http_multi_server: ^3.0.1
meta: ^1.3.0
Expand Down
Loading