Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove UrlLauncher class #6

Merged
merged 3 commits into from
Apr 24, 2017
Merged

Remove UrlLauncher class #6

merged 3 commits into from
Apr 24, 2017

Conversation

szakarias
Copy link
Contributor

No description provided.

mravn-google
mravn-google approved these changes Apr 24, 2017
View reviewed changes
Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/url-launcher/example/lib/main.dart Outdated
@@ -28,7 +28,7 @@ class MyHomePage extends StatefulWidget {

class _MyHomePageState extends State<MyHomePage> {
void _launchUrl() {
UrlLauncher.launch("https://flutter.io");
launch("https://flutter.io");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single quotes?

packages/url-launcher/lib/url_launcher.dart Outdated
}
/// Parse the specified URL string and delegate handling of the same to the
/// underlying platform.
Future<Null> launch(String urlString) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ and extra , + dartfmt might give something that satisfies flutter code style.

@szakarias
Copy link
Contributor Author

Thanks!

@szakarias szakarias merged commit e3f9fdd into flutter:master Apr 24, 2017
jonasbark pushed a commit to jonasbark/plugins that referenced this pull request May 2, 2018
@luigi-agosti
Merge pull request flutter#6 from holykou/master
e759c42 
PR changes for iOS.
cyanglaz pushed a commit to cyanglaz/plugins that referenced this pull request Feb 20, 2019
# This is a combination of 6 commits.
f4bc58f 
# This is the 1st commit message:

review fixes

# This is the commit message #2:

Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

review fix

Co-Authored-By: cyanglaz <[email protected]>
# This is the commit message #3:

Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

Co-Authored-By: cyanglaz <[email protected]>
# This is the commit message flutter#4:

Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

review fix

Co-Authored-By: cyanglaz <[email protected]>
# This is the commit message flutter#5:

Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

Co-Authored-By: cyanglaz <[email protected]>
# This is the commit message flutter#6:

Update packages/in_app_purchase/ios/Classes/InAppPurchasePlugin.m

Co-Authored-By: cyanglaz <[email protected]>
This was referenced Dec 6, 2019
Closed
Closed
srburton added a commit to srburton/plugins that referenced this pull request Feb 21, 2020
@srburton
[FIX] - Gradle
d18ed3e 
       FAILURE: Build failed with an exception.

                    * Where:
                    Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22

                    * What went wrong:
                    A problem occurred evaluating root project 'shared_preferences_macos'.
                    > Failed to apply plugin [id 'com.android.library']
                       > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in
                       C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip

                    * Try:
                    Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

                    * Get more help at https://help.gradle.org

                    BUILD FAILED in 1s
[   +1 ms] Running Gradle task 'assembleAarRelease'... (completed in 2,0s)
[        ] 
           FAILURE: Build failed with an exception.
           
           * Where:
           Build file 'C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\build.gradle' line: 22
           
           * What went wrong:
           A problem occurred evaluating root project 'shared_preferences_macos'.
           > Failed to apply plugin [id 'com.android.library']
              > Minimum supported Gradle version is 5.4.1. Current version is 5.1.1. If using the gradle wrapper, try editing the distributionUrl in
C:\Users\srburton\AppData\Roaming\Pub\Cache\hosted\pub.dartlang.org\shared_preferences_macos-0.0.1+6\android\gradle\wrapper\gradle-wrapper.properties to gradle-5.4.1-all.zip
           
           * Try:
           Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           
           * Get more help at https://help.gradle.org
           
           BUILD FAILED in 1s
           
[   +5 ms] "flutter apk" took 179.497ms.
The plugin shared_preferences_macos could not be built due to the issue above.

#0      throwToolExit (package:flutter_tools/src/base/common.dart:28:3)
flutter#1      buildPluginsAsAar (package:flutter_tools/src/android/gradle.dart:726:7)
flutter#2      _asyncErrorWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:80:45)
#3      _rootRunBinary (dart:async/zone.dart:1146:38)
flutter#4      _CustomZone.runBinary (dart:async/zone.dart:1039:19)
flutter#5      _FutureListener.handleError (dart:async/future_impl.dart:153:20)
flutter#6      Future._propagateToListeners.handleError (dart:async/future_impl.dart:692:47)
flutter#7      Future._propagateToListeners (dart:async/future_impl.dart:713:24)
flutter#8      Future._completeError (dart:async/future_impl.dart:532:5)
flutter#9      _AsyncAwaitCompleter.completeError (dart:async-patch/async_patch.dart:38:15)
flutter#10     buildGradleAar (package:flutter_tools/src/android/gradle.dart)
flutter#11     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
flutter#12     _rootRunUnary (dart:async/zone.dart:1134:38)
flutter#13     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
flutter#14     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
flutter#15     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
flutter#16     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
#17     Future._completeWithValue (dart:async/future_impl.dart:524:5)
flutter#18     _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:32:15)
flutter#19     _completeOnAsyncReturn (dart:async-patch/async_patch.dart:290:13)
flutter#20     _DefaultProcessUtils.run (package:flutter_tools/src/base/process.dart)
flutter#21     _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:73:64)
flutter#22     _rootRunUnary (dart:async/zone.dart:1134:38)
flutter#23     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
flutter#24     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
flutter#25     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
flutter#26     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
flutter#27     Future._completeWithValue (dart:async/future_impl.dart:524:5)
flutter#28     Future.wait.<anonymous closure> (dart:async/future.dart:400:22)
flutter#29     _rootRunUnary (dart:async/zone.dart:1134:38)
flutter#30     _CustomZone.runUnary (dart:async/zone.dart:1031:19)
flutter#31     _FutureListener.handleValue (dart:async/future_impl.dart:139:18)
flutter#32     Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:680:45)
flutter#33     Future._propagateToListeners (dart:async/future_impl.dart:709:32)
flutter#34     Future._completeWithValue (dart:async/future_impl.dart:524:5)
flutter#35     Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:554:7)
flutter#36     _rootRun (dart:async/zone.dart:1126:13)
flutter#37     _CustomZone.run (dart:async/zone.dart:1023:19)
flutter#38     _CustomZone.runGuarded (dart:async/zone.dart:925:7)
flutter#39     _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:965:23)
flutter#40     _microtaskLoop (dart:async/schedule_microtask.dart:43:21)
flutter#41     _startMicrotaskLoop (dart:async/schedule_microtask.dart:52:5)
flutter#42     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
flutter#43     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:175:5)
@srburton srburton mentioned this pull request Feb 21, 2020
Closed
13 tasks
@sumitrvi sumitrvi mentioned this pull request Apr 15, 2020
Merged
sanekyy pushed a commit to optimist-dev/plugins that referenced this pull request Nov 1, 2020
@otopba
Merge pull request flutter#6 from flutter/master
b50c88e 
Update master
@muhammednazil muhammednazil mentioned this pull request Dec 20, 2020
Closed
@PiN73 PiN73 mentioned this pull request Mar 17, 2021
Merged
nt4f04uNd pushed a commit to nt4f04uNd/plugins that referenced this pull request Mar 23, 2021
@acoutts
Merge pull request flutter#6 from bottlepay/fix/refactoring
1acf379 
Draft: Refactor camera features into CameraFeature classes
PeterOmbodi added a commit to PeterOmbodi/plugins that referenced this pull request May 14, 2021
@PeterOmbodi
fix flutter#6
8859b00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mravn-google mravn-google mravn-google approved these changes

@mit-mit mit-mit Awaiting requested review from mit-mit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szakarias @mravn-google