[image_picker] add requestFullMetadata for iOS (optional permissions) - platform interface changes for multi image picking #5914
Conversation
|
@stuartmorgan do you mind taking a look at the PR? |
| ## 2.6.0 | ||
| * Deprecates `getMultiImage` in favor of a new method `getMultiImageWithOptions`. |
...picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart
Show resolved
Hide resolved
...s/image_picker/image_picker_platform_interface/lib/src/types/multi_image_picker_options.dart
Outdated
Show resolved
Hide resolved
It has been added in this PR: #5603. Lately we had a discussion with Stuart about adding the same feature to multi image picking and this PR addresses it. |
| /// The `options` argument controls additional settings that can be used when | ||
| /// picking an image. See [MultiImagePickerOptions] for more details. | ||
| /// | ||
| /// If no images were picked, the return value is null. |
There was a problem hiding this comment.
We should make the return value non-nullable, and return empty for no images, so that we don't have two ways of expressing no files.
| /// compression is not supported for the image that is picked, a warning | ||
| /// message will be logged. | ||
| /// | ||
| /// If null, the image will be returned with the original quality. |
There was a problem hiding this comment.
This comment is stale.
| // found in the LICENSE file. | ||
|
|
||
| /// Specifies options for picking multiple images from the device's gallery. | ||
| class MultiImagePickerOptions { |
There was a problem hiding this comment.
Ideally we would share this with ImagePickerOptions, and extract a shared class that has the elements that are image-specific (i.e., everything here), and then an outer class with anything else. We don't need to do another change to the singe-image version now, but we should prep for it by structuring this that way: all of the fields here should move to a new ImageOptions, and then MultiImagePickerOptions should have one ImageOptions field. Eventually we can switch the single-image version to use ImageOptions instead of these four fields too.
|
@cyanglaz @stuartmorgan could you do another review, please? 🙂 |
stuartmorgan
added
the
autosubmit
|
Looks like |
stuartmorgan
removed
the
autosubmit
…rmissions) - platform interface changes for multi image picking (flutter/plugins#5914)
… - platform interface changes for multi image picking (flutter#5914) Platform interface changes for flutter#5915 - adding possibility to disable full metadata when picking multiple images
… - platform interface changes for multi image picking (flutter#5914) Platform interface changes for flutter#5915 - adding possibility to disable full metadata when picking multiple images
Description
Platform interface changes for #5915 - adding possibility to disable full metadata when picking multiple images
Related issues
flutter/flutter#65995
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).