This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[camera] Remove a potential deadlock on Android #5788
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the scenario fixed by this PR:
dispose
method called)In that case, the native Android code will call
onDisconnected
fromCameraDevice.StateCallback
.In this call, the
close()
method is launched but never ends becausestopBackgroundThread
is blocked in thejoin()
method.To prevent this, I have simply added a timeout.
2500 milliseconds is totally arbitrary. I can change it.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.