Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Suppress deprecation warnings #5049

Merged
merged 3 commits into from
May 20, 2022
Merged

[google_sign_in] Suppress deprecation warnings #5049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5652c21
Suppress `deprecation` warnings in `GoogleSignInPlugin`
asashour Mar 14, 2022
3f15695
Update `CHANGELOG`
asashour May 6, 2022
2f31e08
Update `pubspec`
asashour May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_android/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.2.8

* Suppresses `deprecation` warnings (for using Android V1 embedding).

## 5.2.7

* Fixes library_private_types_in_public_api, sort_child_properties_last and use_key_in_widget_constructors
Expand Down
3 changes: 3 additions & 0 deletions ..._in_android/android/src/main/java/io/flutter/plugins/googlesignin/GoogleSignInPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public void initInstance(
}

@VisibleForTesting
@SuppressWarnings("deprecation")
public void setUpRegistrar(PluginRegistry.Registrar registrar) {
delegate.setUpRegistrar(registrar);
}
Expand Down Expand Up @@ -267,6 +268,7 @@ public static class Delegate implements IDelegate, PluginRegistry.ActivityResult

private final Context context;
// Only set registrar for v1 embedder.
@SuppressWarnings("deprecation")
private PluginRegistry.Registrar registrar;
// Only set activity for v2 embedder. Always access activity from getActivity() method.
private Activity activity;
Expand All @@ -282,6 +284,7 @@ public Delegate(Context context, GoogleSignInWrapper googleSignInWrapper) {
this.googleSignInWrapper = googleSignInWrapper;
}

@SuppressWarnings("deprecation")
public void setUpRegistrar(PluginRegistry.Registrar registrar) {
this.registrar = registrar;
registrar.addActivityResultListener(this);
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_android/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_android
description: Android implementation of the google_sign_in plugin.
repository: https://github.com/flutter/plugins/tree/main/packages/google_sign_in/google_sign_in_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+google_sign_in%22
version: 5.2.7
version: 5.2.8

environment:
sdk: ">=2.14.0 <3.0.0"
Expand Down