This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[file_selector]Improve API docs and examples #4824
Merged
fluttergithubbot
merged 27 commits into
flutter:main
from
TowaYamashita:towayamashita-patch-1
Jun 9, 2022
Merged
Changes from 17 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6c71647
Add detail comment in file_selector
TowaYamashita b021530
change sample code for file_selector
TowaYamashita a6cc58f
Update CHAGELOG.md
TowaYamashita 08a3dea
Fix CHANGELOG version
TowaYamashita 2b391d6
Remove const from MyApp() in widget test
TowaYamashita fe10180
Sort directive sections alphabetically
TowaYamashita 09d9bf8
Update Authors
TowaYamashita a3a820d
Fix my mailaddress
TowaYamashita 422b133
remove accidentally created test
TowaYamashita 63bbfe8
fix comment of function in file_selector.dart
TowaYamashita 55bd1a5
install path_provider
TowaYamashita d51b01c
change initial directory to useful example
TowaYamashita cbed80f
fix not to regress web
TowaYamashita d9dc0bc
fix typo
TowaYamashita 229657d
fix button labels not to change in example
TowaYamashita d190b51
fix CHANGELOG.md to follow CHANGELOG style
TowaYamashita c31eea7
Merge branch 'main' into towayamashita-patch-1
TowaYamashita 750f8b7
Merge branch 'main' into towayamashita-patch-1
stuartmorgan ef47a7a
Remove some use of initialDirectory, and add comments on the others
stuartmorgan e0eac1a
Clean up comments
stuartmorgan bbe266d
Missing newline
stuartmorgan bd4e16b
Accidentally missed changes
stuartmorgan fda0ed5
Fix bug in singe-image example
stuartmorgan e982e74
Convert to code-excerpt
stuartmorgan 28fe8a4
Apply suggestions from code review
stuartmorgan 93a87a5
Merge branch 'main' into towayamashita-patch-1
stuartmorgan 73d596e
Update save example
stuartmorgan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,3 +63,4 @@ Aleksandr Yurkovskiy <[email protected]> | |
Anton Borries <[email protected]> | ||
Alex Li <[email protected]> | ||
Rahul Raj <[email protected]> | ||
TowaYamashita <[email protected]> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
## NEXT | ||
|
||
* Improve API docs and examples. | ||
|
||
## 0.8.4+1 | ||
|
||
* Adds README information about macOS entitlements. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ dependencies: | |
path: ../ | ||
flutter: | ||
sdk: flutter | ||
path_provider: ^2.0.9 | ||
|
||
dev_dependencies: | ||
flutter_test: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not exempt from version changes; I'm not sure why you've changed this to
NEXT
since the previous review, but that's incorrect.