This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[ci] Skip Android webview FTL tests on stable #4730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
approved these changes
Feb 3, 2022
Member
|
(This will need to land in red to fix the submit-queue check) |
ditman
reviewed
Feb 3, 2022
ditman
reviewed
Feb 3, 2022
These tests crash on stable due to flutter/flutter#96661 now that 2.10 has been released to stable. Fixes out-of-band tree closure from the 2.10 release.
stuartmorgan-g
force-pushed
the
skip-webview-android-stable
branch
from
38cad97 to
3215ac8
Compare
Remove unneeded `fi`
Contributor
Author
|
🤦🏻 Thanks. I hate changing CI scripts that can't be tested locally. |
Member
|
No problem! I hope this goes through now :D |
Contributor
Author
|
Landing on red to fix tree. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests crash on stable due to
flutter/flutter#96661 now that 2.10 has been
released to stable.
Fixes out-of-band tree closure from the 2.10 release.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).