Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Bump minimum Flutter version and iOS deployment target #4352

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 16, 2021

Flutter apps run on 2.4.0-0.0.pre and later will be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable and iOS 8 support has been dropped, change the plugin minimum iOS version to 9.0.

  • Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption Merge null-safety plugins #3324 (there's recent precedent).
  • Fix broken README link.
  • Remove reference to deprecated VALID_ARCHS Xcode build setting. Confirmed this plugin builds for arm64 simulators.

Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.

in_app_purchase_ios part of flutter/flutter#84198

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman
Copy link
Member Author

jmagman commented Sep 16, 2021

I'm not sure how versioning happens with endorsed federated plugins. Do I also need to bump the "parent" pubspec (or whatever the term is)?
https://github.com/flutter/plugins/blob/master/packages/in_app_purchase/in_app_purchase/pubspec.yaml

@cyanglaz
Copy link
Contributor

I'm not sure how versioning happens with endorsed federated plugins. Do I also need to bump the "parent" pubspec (or whatever the term is)?
https://github.com/flutter/plugins/blob/master/packages/in_app_purchase/in_app_purchase/pubspec.yaml

The parent depends on in_app_purchase_ios: ^0.1.1, which will resolve to 0.1.3+4, so it should be fine.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. and removed waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. labels Sep 17, 2021
@jmagman
Copy link
Member Author

jmagman commented Sep 17, 2021

Actually I missed a few (@available(iOS 8.3, *)!

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 17, 2021
@fluttergithubbot fluttergithubbot merged commit f9ec026 into flutter:master Sep 17, 2021
@jmagman jmagman deleted the iap-9 branch September 17, 2021 22:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: in_app_purchase platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants