Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Give the labeler access to PRs #4348

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Give the labeler access to PRs #4348

merged 1 commit into from
Sep 14, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Sep 14, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM (in that it seems to work; I didn't see any docs about this in a quick look).

flutter/packages will need this as well.

@Hixie
Copy link
Contributor Author

Hixie commented Sep 14, 2021

A whole bunch of tests failed with Unable to start WebDriver Session for Flutter for Web testing., any ideas? cc @yjbanov

@Hixie
Copy link
Contributor Author

Hixie commented Sep 14, 2021

RSLGTM (in that it seems to work; I didn't see any docs about this in a quick look).

Yeah me either. It's quite concerning how underdocumented the security aspects of GitHub actions are.

flutter/packages will need this as well.

flutter/packages#467

@stuartmorgan
Copy link
Contributor

A whole bunch of tests failed with Unable to start WebDriver Session for Flutter for Web testing., any ideas? cc @yjbanov

That's a Cirrus issue; see #4349

@stuartmorgan
Copy link
Contributor

The tree is green, so I'm going to land this to fix PRs. (I'm pretty sure this PR doesn't have a web regression hiding behind that failure 🙂)

@stuartmorgan stuartmorgan merged commit 7fff936 into master Sep 14, 2021
@stuartmorgan stuartmorgan deleted the Hixie-patch-1 branch September 14, 2021 22:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2021
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Sep 14, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants