Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Enable the new Windows targets #4325

Merged
merged 2 commits into from
Sep 9, 2021
Merged

[ci] Enable the new Windows targets #4325

merged 2 commits into from
Sep 9, 2021

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented Sep 8, 2021

Now that the builders have propagated, enable all the new tests and remove the obsolete versions.

Fixes one unit test that was failing on Windows so that new target will be green.

Fixes flutter/flutter#82729
Fixes flutter/flutter#86113
Fixes flutter/flutter#88294

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

Now that the builders have propagated, enable all the new tests and remove the obsolete versions.
@stuartmorgan stuartmorgan marked this pull request as draft September 8, 2021 18:46
@google-cla google-cla bot added the cla: yes label Sep 8, 2021
@stuartmorgan stuartmorgan marked this pull request as ready for review September 8, 2021 20:36
@stuartmorgan stuartmorgan merged commit f460b79 into master Sep 9, 2021
@stuartmorgan stuartmorgan deleted the windows-ci-enable branch September 9, 2021 13:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2021
NickalasB added a commit to NickalasB/plugins that referenced this pull request Sep 10, 2021
* master:
  [webview_flutter] Add download listener to Android webview (flutter#4322)
  [video_player] add support for content-uri based videos (flutter#4330)
  [webview_flutter] Implementation of the webview_flutter_platform_interface package (flutter#4302)
  [camera] Bump minimum Flutter version and iOS deployment target (flutter#4327)
  [video_player] interface: add support for content-uri based videos (android only) (flutter#4307)
  Ignore unnecessary_import in legacy analysis options (flutter#4129)
  [ci] Enable the new Windows targets (flutter#4325)

# Conflicts:
#	packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/FlutterWebView.java
#	packages/webview_flutter/webview_flutter/android/src/main/java/io/flutter/plugins/webviewflutter/WebViewBuilder.java
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
Now that the builders have propagated, enable all the new tests and remove the obsolete versions.
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
Now that the builders have propagated, enable all the new tests and remove the obsolete versions.
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Now that the builders have propagated, enable all the new tests and remove the obsolete versions.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants