This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Bring up new Windows test targets #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the new generic plugins recipe to add a number of new Windows tests
that have recently gained tool support, but not yet added to the LUCI
builds:
- New targets:
- The "build all plugins" test (master and stable)
- UWP build tests (master only, since UWP is not on stable yet)
- Tool tests (master only with existing tool tests on Linux)
- Replacement versions of the existing builders but with names that
match the Cirrus naming to make the parallels in testing easier
to understand in the GitHub UI and configs.
- Modification of existing targets:
- Adds Windows native unit tests to the existing script.
CaseyHillers
reviewed
Sep 3, 2021
.ci.yaml
Outdated
| @@ -60,6 +62,88 @@ targets: | |||
| ] | |||
| scheduler: luci | |||
|
|
|||
| - name: windows-build+platform-tests master | |||
There was a problem hiding this comment.
target names must follow the format $platform $name
So Windows build+platform-tests master. I'll send a PR to update this in the CI_YAML.md
| timeout: 30 | ||
| properties: | ||
| # TODO(stuartmorgan): Uncomment when removing bringup. | ||
| #add_recipes_cq: "true" |
There was a problem hiding this comment.
Is this necessary? My expectation is this could land in this PR
There was a problem hiding this comment.
Probably not for this particular one since it's a copy-paste, but in general I would rather make sure a new target actually works in the wild before adding it to the recipe CQ since I really don't want to bring the recipes repo to a standstill by throwing untested things into its pipeline for landing changes.
There was a problem hiding this comment.
This is a really good insight! I'll have to add it to the documentation (and later as a test)
| tasks: | ||
| - name: "prepare tool" | ||
| script: .ci/scripts/prepare_tool.sh | ||
| - name: "build examples" | ||
| - name: "build examples (Win32)" |
There was a problem hiding this comment.
I don't think these target yaml files need strings around the name
CaseyHillers
approved these changes
Sep 7, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2021
NickalasB
added a commit
to NickalasB/plugins
that referenced
this pull request
Sep 8, 2021
* master: [ci] Fix and standardize target/task names (flutter#4323) Bring up new Windows test targets (flutter#4311)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 8, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2021
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
Uses the new generic plugins recipe to add a number of new Windows tests
that have recently gained tool support, but not yet added to the LUCI
builds:
- New targets:
- The "build all plugins" test (master and stable)
- UWP build tests (master only, since UWP is not on stable yet)
- Tool tests (master only with existing tool tests on Linux)
- Replacement versions of the existing builders but with names that
match the Cirrus naming to make the parallels in testing easier
to understand in the GitHub UI and configs.
- Modification of existing targets:
- Adds Windows native unit tests to the existing script.
amantoux
pushed a commit
to amantoux/plugins
that referenced
this pull request
Sep 27, 2021
Uses the new generic plugins recipe to add a number of new Windows tests
that have recently gained tool support, but not yet added to the LUCI
builds:
- New targets:
- The "build all plugins" test (master and stable)
- UWP build tests (master only, since UWP is not on stable yet)
- Tool tests (master only with existing tool tests on Linux)
- Replacement versions of the existing builders but with names that
match the Cirrus naming to make the parallels in testing easier
to understand in the GitHub UI and configs.
- Modification of existing targets:
- Adds Windows native unit tests to the existing script.
KyleFin
pushed a commit
to KyleFin/plugins
that referenced
this pull request
Dec 21, 2021
Uses the new generic plugins recipe to add a number of new Windows tests
that have recently gained tool support, but not yet added to the LUCI
builds:
- New targets:
- The "build all plugins" test (master and stable)
- UWP build tests (master only, since UWP is not on stable yet)
- Tool tests (master only with existing tool tests on Linux)
- Replacement versions of the existing builders but with names that
match the Cirrus naming to make the parallels in testing easier
to understand in the GitHub UI and configs.
- Modification of existing targets:
- Adds Windows native unit tests to the existing script.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the new generic plugins recipe to add a number of new Windows tests
that have recently gained tool support, but not yet added to the LUCI
builds:
match the Cirrus naming to make the parallels in testing easier
to understand in the GitHub UI and configs.
All but the modification change are in bringup mode, so won't affect the repo until a follow-up
removes that flag.
Part of flutter/flutter#86113
Part of flutter/flutter#82729
Pre-launch Checklist
dart format.)[shared_preferences]///).